-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New key breaks r docker container build #322
Conversation
A new key for the R repo (see https://cloud.r-project.org/) breaks building the R container. This PR fixes that.
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 89.30% 89.11% -0.19%
==========================================
Files 73 73
Lines 1533 1498 -35
Branches 90 90
==========================================
- Hits 1369 1335 -34
+ Misses 135 134 -1
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but why do we need to change the R version here?
I couldn't find an official repository that still contains R 4.0, the old one is not available anymore. Not sure what the policy for additional packages was, should they be added to the |
That makes sense. Thanks! |
* upstream/main: Convert normalizers to return anndata (openproblems-bio#329) require anndata<0.8 (openproblems-bio#336) Fix GPG key for R install (openproblems-bio#334) Fix R dependencies for docker build (openproblems-bio#331) Jamboree dimensionality reduction datasets (openproblems-bio#316) Jamboree dimensionality reduction metrics (openproblems-bio#317) use cmake==3.18.4 for multicoretsne build (openproblems-bio#328) Update 'master' to 'main' on CI (openproblems-bio#326) New key breaks r docker container build (openproblems-bio#322)
A new key for the R repo (see https://cloud.r-project.org/) breaks building the R container.
This PR fixes that.
Submission type