-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jamboree dimensionality reduction datasets #316
Jamboree dimensionality reduction datasets #316
Conversation
* master: Update alra.py Update alra.R pre-commit Create alra.R pre-commit Update alra.py make var names unique for tenx data loader Force docker_build on `master` Dockerfile bugfix Update CONTRIBUTING.md Update README.md Create alra.py Delete alra.py Create alra.py
catching up from master
* master: fix region fix nf wkdir use env.BRANCH rm echo BRANCH -> WKDIR for s3 set branch variable in S3 setup job Fix s3 bucket clash Dimred methods preprocessing (openproblems-bio#301) Add trustworthiness score for dimred task (openproblems-bio#258) Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298) Update README.md Update README.md Update README.md
* master: Update alra.py (openproblems-bio#304) updated template for PR with PR evaluation checks (openproblems-bio#314)
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 89.30% 87.81% -1.49%
==========================================
Files 73 75 +2
Lines 1533 1559 +26
Branches 90 91 +1
==========================================
Hits 1369 1369
- Misses 135 161 +26
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your help with this @lazappi ! Approving merger
* upstream/main: Convert normalizers to return anndata (openproblems-bio#329) require anndata<0.8 (openproblems-bio#336) Fix GPG key for R install (openproblems-bio#334) Fix R dependencies for docker build (openproblems-bio#331) Jamboree dimensionality reduction datasets (openproblems-bio#316) Jamboree dimensionality reduction metrics (openproblems-bio#317) use cmake==3.18.4 for multicoretsne build (openproblems-bio#328) Update 'master' to 'main' on CI (openproblems-bio#326) New key breaks r docker container build (openproblems-bio#322)
@lazappi any idea why this dataset was included but not used? https://app.codecov.io/gh/openproblems-bio/openproblems/blob/main/openproblems/data/mouse_blood_olssen_labelled.py |
No, I probably just missed something when approving the initial PR. If you remind what needs to be added for it to be used I can do that. |
Actually it looks like the task dataset function just needs to be added to |
* simplify get_dataset_info component * fix script * change default into example * fix script * fix script
* simplify get_dataset_info component * fix script * change default into example * fix script * fix script Former-commit-id: 4b7c085
Submission type
Testing
Submission guidelines
PR review checklist
This PR will be evaluated on the basis of the following checks:
__init__.py
and were tested in the pipelineDescription
This PR contains the following new dimensionality reduction datasets from the jamboree: