Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamboree dimensionality reduction datasets #316

Merged
merged 11 commits into from
Mar 16, 2022

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented May 14, 2021

Submission type

  • This submission adds a new dataset
  • This submission adds a new method
  • This submission adds a new metric
  • This submission adds a new task
  • This submission adds a new Docker image
  • This submission fixes a bug (link to related issue: )
  • This submission adds a new feature not listed above

Testing

  • This submission was written on a forked copy of SingleCellOpenProblems
  • GitHub Actions "Run Benchmark" tests are passing on this base branch of this pull request (include link to passed test: )
  • If this pull request is not ready for review (including passing the "Run Benchmark" tests), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

  • This submission follows the guidelines in our Contributing document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist

This PR will be evaluated on the basis of the following checks:

  • The task addresses a valid open problem in single-cell analysis
  • The latest version of master is merged and tested
  • The methods/metrics are imported to __init__.py and were tested in the pipeline
  • Method and metric decorators are annotated with paper title, year, author, code version, and date
  • The README gives an outline of the methods, metrics and datasets in the folder
  • The README provides a satisfactory task explanation (for new tasks)
  • The sample test data is appropriate to test implementation of all methods and metrics (for new tasks)

Description

This PR contains the following new dimensionality reduction datasets from the jamboree:

Dataset Author Issue Original PR
Olsson mouse blood @mvinyard #252 lazappi/pull/2

mvinyard and others added 10 commits March 29, 2021 23:22
* master:
  Update alra.py
  Update alra.R
  pre-commit
  Create alra.R
  pre-commit
  Update alra.py
  make var names unique for tenx data loader
  Force docker_build on `master`
  Dockerfile bugfix
  Update CONTRIBUTING.md
  Update README.md
  Create alra.py
  Delete alra.py
  Create alra.py
* master:
  fix region
  fix nf wkdir
  use env.BRANCH
  rm echo
  BRANCH -> WKDIR for s3
  set branch variable in S3 setup job
  Fix s3 bucket clash
  Dimred methods preprocessing (openproblems-bio#301)
  Add trustworthiness score for dimred task (openproblems-bio#258)
  Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298)
  Update README.md
  Update README.md
  Update README.md
* master:
  Update alra.py (openproblems-bio#304)
  updated template for PR with PR evaluation checks (openproblems-bio#314)
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #316 (d64ce94) into main (4394dbb) will decrease coverage by 1.48%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   89.30%   87.81%   -1.49%     
==========================================
  Files          73       75       +2     
  Lines        1533     1559      +26     
  Branches       90       91       +1     
==========================================
  Hits         1369     1369              
- Misses        135      161      +26     
  Partials       29       29              
Flag Coverage Δ
unittests 87.81% <0.00%> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openproblems/data/mouse_blood_olssen_labelled.py 0.00% <0.00%> (ø)
..._reduction/datasets/mouse_blood_olssen_labelled.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4394dbb...d64ce94. Read the comment docs.

@mvinyard mvinyard self-requested a review May 28, 2021 19:30
Copy link
Collaborator

@mvinyard mvinyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your help with this @lazappi ! Approving merger

@mvinyard mvinyard requested a review from LuckyMD May 28, 2021 19:35
@scottgigante-immunai scottgigante-immunai merged commit b6a240b into openproblems-bio:main Mar 16, 2022
lazappi added a commit to lazappi/openproblems that referenced this pull request Mar 24, 2022
* upstream/main:
  Convert normalizers to return anndata (openproblems-bio#329)
  require anndata<0.8 (openproblems-bio#336)
  Fix GPG key for R install (openproblems-bio#334)
  Fix R dependencies for docker build (openproblems-bio#331)
  Jamboree dimensionality reduction datasets (openproblems-bio#316)
  Jamboree dimensionality reduction metrics (openproblems-bio#317)
  use cmake==3.18.4 for multicoretsne build (openproblems-bio#328)
  Update 'master' to 'main' on CI (openproblems-bio#326)
  New key breaks r docker container build (openproblems-bio#322)
@scottgigante-immunai
Copy link
Collaborator

@lazappi
Copy link
Collaborator Author

lazappi commented Apr 7, 2022

No, I probably just missed something when approving the initial PR. If you remind what needs to be added for it to be used I can do that.

@scottgigante-immunai
Copy link
Collaborator

Actually it looks like the task dataset function just needs to be added to __init__.py. Easy peasy.

@lazappi lazappi deleted the dimred-datasets branch April 11, 2022 08:48
rcannood added a commit that referenced this pull request Sep 4, 2024
* simplify get_dataset_info component

* fix script

* change default into example

* fix script

* fix script
rcannood added a commit that referenced this pull request Sep 4, 2024
* simplify get_dataset_info component

* fix script

* change default into example

* fix script

* fix script

Former-commit-id: 4b7c085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants