Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4.4.1 proposal #5835

Merged
merged 114 commits into from
Mar 22, 2016
Merged

V4.4.1 proposal #5835

merged 114 commits into from
Mar 22, 2016

Conversation

MylesBorins
Copy link
Contributor

2016-03-22, Version 4.4.1 'Argon' (LTS), @thealphanerd

This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes

  • build:
    • Updated Logos for the OSX + Windows installers
    • New option to select your VS Version in the Windows installer
      • (julien.waechter) #4645
    • Support Visual C++ Build Tools 2015
  • tools:

mscdex and others added 30 commits March 21, 2016 12:57
@mscdex
stream: fix no data on partial decode
04db9ef 
Before this commit, it was possible to push a partial character
to a readable stream where it was decoded as an empty string and
then added to the internal buffer. This caused the stream to not
emit any data, even when the rest of the character bytes were pushed
separately, because of a non-zero length check of the first chunk in
the internal buffer.

Fixes: #5223
PR-URL: #5226
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@estliberitas
doc: fix links in Addons docs
cd78ff9 
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juliepagano
doc: clarify code of conduct reporting
67245fa 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@estliberitas
http,util: fix typos in comments
2ce83bd 
Fix several typos in comments.

PR-URL: #5279
Reviewed-By: James M Snell <[email protected]>
@Fishrock123
doc: add "building node with ninja" guide
ebbc64b 
PR-URL: #4767
Refs: nodejs/docs#38
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Stephan Belanger <[email protected]>
@rvagg
doc: add Сковорода Никита Андреевич to the CTC
d09b44f 
Approved at CTC meeting
#5409
Reviewers are CTC members who voted for this.

PR-URL: #5278
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
@rvagg
doc: add Ali Ijaz Sheikh to the CTC
4e469d5 
Approved at CTC meeting
#5409
Reviewers are CTC members who voted for this.

PR-URL: #5277
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
@rvagg
doc: add Rich Trott to the CTC
a2a32b7 
Approved at CTC meeting
#5409
Reviewers are CTC members who voted for this.

PR-URL: #5276
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
@rvagg
doc: add Evan Lucas to the CTC
2964620
doc: document fs.datasync(Sync)
04d16eb 
The APIs are implemented but currently not documented.

PR-URL: #5402
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@strawbrary
doc: update V8 URL
3168e6b 
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <[email protected]>
@joaocgreis
win,build: support Visual C++ Build Tools 2015
0e97a3e 
Invoke MSBuild specifying the target platform as generated by Gyp.

Reviewed-By: James M Snell <[email protected]>
PR-URL: #5627
@subzey
lib: freelist: use .pop() for allocation
b690916 
Array#pop() is known to be faster than Array#shift().
To be exact, it's O(1) vs. O(n). In this case there's no difference
from which side of the "pool" array the object is retrieved,
so .pop() should be preferred.

PR-URL: #2174
Reviewed-By: mscdex - Brian White <[email protected]>
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
@Fishrock123
doc: add onboarding resources
470a9ca 
PR-URL: #3726
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Sequoia
doc: add info to docs on how to submit docs patch
17a7430 
The docs mentioned that the docs source live in
the node source, but did not link to same.

PR-URL: #4591
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@greenjava
build: add option to select VS version
dac4e64 
This changes vcbuild.bat to accept a new parameter (vc2015 or vc2013)
to select the version of Visual Studio to use.

PR-URL: #4645
Reviewed-By: João Reis <[email protected]>
@cjihrig
src: return UV_EAI_NODATA on empty lookup
7c3b844 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: #4545
PR-URL: #4715
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@evanlucas
stream: prevent object map change in ReadableState
fb5ba6b 
ReadableState has the resumeScheduled property that helps determine if
a stream should be resumed. It was not assigned in the constructor.
When stream.resume is called on a readable stream that is not flowing,
it is set to true. This changes the property map of the ReadableState
which can cause a deopt in onEofChunk and needMoreData.

PR-URL: #4761
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott
test: move cluster tests to parallel
068b0cb 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: #4736
Ref: #4739
PR-URL: #4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@kevinoid
doc: clarify when writable.write callback is called
0830bb4 
The current documentation for writable.write only specifies that the
callback is called "once the data has been fully handled".  It is
ambiguous whether this means "successfully handled" and, if so,
whether the callback is called if the data can not be successfully
handled (i.e. an error occurs).

The ambiguity is not only in the documentation.  The stream class
implementations differ on this point.  stream.Writable invokes the
callback with any errors that occur during parameter checking or
during calls to _write.  However, not all classes return all errors
to _write. zlib.Zlib does pass argument and state errors to the
_write (_transform) callback, but does not pass data errors.
http.OutgoingMessage passes argument type errors and some other types
of errors, but not all.

This inconsistency is behind issue #1746 and, I suspect, other issues
in client code which passes a callback to write.

This commit takes no position on whether the callback error behavior
should changed, but simply attempts to document the current behavior
in a way that is open to changes so that users are not caught by
surprise.

PR-URL: #4810
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@entertainyou
buffer: remove duplicated code in fromObject
b816044 
Add fromArrayLike() to handle logic of copying in values from array-like
argument.

PR-URL: #4948
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@aayn
test: remove unneeded bind() and related comments
6386f62 
As mentioned in the comment of the changed file, "a libuv limitation
makes it necessary to bind()". But, that is not the case in this test.
The subsequent call to send() results in an implicit bind().

PR-URL: #5023
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@evanlucas
stream: prevent object map change in TransformState
242a65e 
TransformState has the writeencoding property that gets set on the
first _write. It is not declared when the transform state is initially
constructed and can cause a deopt.

PR-URL: #5032
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex
string_decoder: fix performance regression
cc0e36f 
This commit reverts the const usage introduced by 68a6abc
because v8 currently cannot optimize functions that contain
these uses of const (unsupported phi use of const variable).
The performance difference in this case can be up to ~130%
for non-ascii/binary string encodings.

PR-URL: #5134
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@princejwesley
repl: handle quotes within regexp literal
e7f45f0 
PR-URL: #5117
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
doc: add note for binary safe string reading
ca17f91 
`readable.setEncoding(null)` - may be the most preferable way to proxy
a binary data without any encoding/decoding overhead

PR-URL: #5155
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@vaibhav93
doc: update removeListener behaviour
b1d580c 
This commit updates events doc to describe removeListener behaviour
when it is called within a listener. An example is added to make
it more evident.

A test is also incuded to make this behaviour consistent in future
releases.

Fixes: #4759

PR-URL: #5201

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@dimhotepus
build: skip msi build if WiX is not found
46a5d51 
If none of VS2013/VS2015 WiX installs are found on a builder
machine, skip node build and notify user about.

PR-URL: #5220
Reviewed-By: João Reis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@mscdex
http: remove unnecessary check
ca5d7a8 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex
http: remove old, confusing comment
f982632 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
cjihrig and others added 9 commits March 21, 2016 13:07
@cjihrig
tools: support testing known issues
7501ddc 
This commit adds a known_issues directory to the test directory
for scripts that reproduce known bugs. Since these scripts are
expected to fail, it also adds a --expect-fail flag to test.py
which reports tests as successful when they fail.

Refs: nodejs/testing#18
Backport-URL: #5785
PR-URL: #5528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

Conflicts:
	tools/test.py
@cjihrig
test: bug repro for vm function redefinition
9952bcf 
This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.

Refs: #548
Backport-URL: #5785
PR-URL: #5528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
tools: update gyp to b3cef02
4b6a8f4 
Includes two patches for AIX. Adds support for both 32-bit and 64-bit
files[0] and uses -RPf for cp instead of -af (which is unsupported)[1]

[0] https://codereview.chromium.org/1319663007
[1] https://codereview.chromium.org/1368133002

PR-URL: #3487
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
tools: fix gyp to work on MacOSX without XCode
8ffef48 
This issue has already submitted to the upstream in
https://code.google.com/p/gyp/issues/detail?id=477
Use this commit until the upstream is to be fixed.

PR-URL: #1325
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@kthelgason
test: eval a strict function
666d369 
PR-URL: #5250
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jrit
doc: topic blocking vs non-blocking
5f54bd2 
The need for an overview of blocking vs non-blocking was
identified in the docs WG Q1 roadmap. As there are several
topics also pending creation, this one tries to hit the correct
level of detail based on completion of the others.  One
which is referenced is
https://github.com/nodejs/node/pull/4936/files and URLs
within this PR need to change based on where that will land
on the node website.

PR-URL: #5326
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@jbergstroem
build: don't install github templates
067ce9b 
Avoid putting github templates in the source tarballs.

PR-URL: #5612
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
deps: update openssl config
19ae308 
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in
opensslconf.h

Fixes: nodejs/Release#85
PR-URL: #5630
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@WebReflection
doc: fix typo in synchronous randomBytes example
1e05f37 
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added meta Issues and PRs related to the general management of the project. v4.x labels Mar 21, 2016
@MylesBorins
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/2000/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/121/

@MylesBorins
Copy link
Contributor Author

CI is green and citgm is looking good

RC-1 build: https://ci-release.nodejs.org/job/iojs+release/477/

@Fishrock123
Copy link
Contributor

@thealphanerd mind correcting iojs/io.js#1325 to nodejs/node?

@MylesBorins
Copy link
Contributor Author

@Fishrock123 thanks for the heads up... got it

@Trott
Copy link
Member

Trott commented Mar 22, 2016

Not sure if it should be noted here or somewhere else or not at all, but there's a typo in one of the notable changes: New option to select you VS Version -> New option to select your VS Version

Trott
Trott reviewed Mar 22, 2016
View reviewed changes
CHANGELOG.md
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) [#5401](https://github.com/nodejs/node/pull/5401)
- (Robert Jefe Lindstaedt) [#5531](https://github.com/nodejs/node/pull/5531)
- New option to select you VS Version in the Windows installer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: you -> your

2016-03-22, Version v4.4.1 'Argon' (LTS)
5368455 
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325
@MylesBorins
Copy link
Contributor Author

Release Build: https://ci-release.nodejs.org/job/iojs+release/478/

@MylesBorins MylesBorins merged commit 5368455 into v4.x Mar 22, 2016
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
Working on v4.4.2
ab5ad06 
PR-URL: #5835
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
2016-03-22, Version v4.4.1 'Argon' (LTS)
2c67289 
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

PR-URL: #5835
This was referenced Mar 23, 2016
Closed
Merged
@MylesBorins MylesBorins deleted the v4.4.1-proposal branch April 8, 2016 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.