repl: handle quotes within regexp literal in multiline mode #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Feb 9, 2016
PR-URL: #5117 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Thanks! Landed in 211018f with slight modification to the commit title to fit the 50 character limit. |
rvagg
pushed a commit
that referenced
this pull request
Feb 10, 2016
PR-URL: #5117 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Marking lts-watch but this one is a bit questionable. @nodejs/lts any thoughts? If it does pull back, it should definitely sit in master or v5 for a bit first. |
|
I'm fine with this coming back, but obviously with little urgency |
|
+1 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
PR-URL: #5117 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5117 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5113