doc: Explicitly indicate that EventEmitter's listeners will still be invoked if they were removed during the emit cycle #4759
Labels
doc
Issues and PRs related to the documentations.
good first issue
Issues that are suitable for first-time contributors.
Comments
|
Documentation patches are welcome. |
Fishrock123
added
doc
dirceu
added a commit
to dirceu/node
that referenced
this issue
Feb 12, 2016
Fix based on nodejs#4764 by @drjokepu. Fixes: nodejs#4759
vaibhav93
added a commit
to vaibhav93/node
that referenced
this issue
Feb 12, 2016
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. fixes nodejs#4759
evanlucas
pushed a commit
that referenced
this issue
Mar 14, 2016
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. Fixes: #4759 PR-URL: #5201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
rvagg
pushed a commit
that referenced
this issue
Mar 16, 2016
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. Fixes: #4759 PR-URL: #5201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Mar 17, 2016
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. Fixes: #4759 PR-URL: #5201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Mar 21, 2016
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. Fixes: #4759 PR-URL: #5201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in nodejs/node-v0.x-archive#7872, EventEmitter's listeners are still called if they are removed during the emit() cycle. It was agreed that this is the intended behavior, however, there is nothing in EventEmitter's documentation that would explicitly indicate that.
I think the documentation needs to be updated to clarify this behavior, because it's not necessarily obvious.
The text was updated successfully, but these errors were encountered: