Typo in synchronous randomBytes example #5781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string template was closed after `${buf.length}` causing a syntax error within the example.
r-52
added
crypto
|
LGTM |
|
LGTM. Thanks Andrea. |
|
LGTM |
|
@benjamingr this is probably the smallest/easiest PR I've ever made so no problems at all ;-) |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 18, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.
PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
|
Landed in ac6af73. |
|
apologies I haven't fully followed the commit style guide. thanks for merging it |
|
No worries :-) It's simple to fix. Really appreciate the contribution! |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.
PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.
PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.
PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string template was closed after
${buf.length}causing a syntax error within the example.