Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fix setRenderTargetTextures(). #23644

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 3, 2022

Fixed #23642.

Description

Ensures setRenderTargetTextures() sets the right flag.

@Mugen87 Mugen87 added this to the r139 milestone Mar 3, 2022
@mrdoob mrdoob merged commit b5b9aad into mrdoob:dev Mar 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2022

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2022

Cherry-picked into the master branch and included in 0.138.3.

@Mugen87 Mugen87 modified the milestones: r139, r138 Mar 4, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
qiweicao pushed a commit to qiweicao/three.js that referenced this pull request Apr 9, 2024
nianxy pushed a commit to qiweicao/three.js that referenced this pull request Apr 10, 2024
nianxy pushed a commit to oppenfuture/three.js that referenced this pull request Apr 10, 2024
* WebGLMultipleRenderTargets: Add Options to Constructor (mrdoob#22772)

* WebGLMultipleRenderTargets: Add Options to Constructor

* Update WebGLMultipleRenderTargets Documentation with new options

* Add line break

* WebGLMultipleRenderTargets: Use default parameter.

Co-authored-by: Michael Herzog <[email protected]>

* WebGLRenderTarget: Clone depthTexture in copy(). (mrdoob#23462)

* Remove WebGLMultisampleRenderTarget. (mrdoob#23455)

* Remove WebGLMultisampleRenderTarget.

* THREE.Legacy.js: Add WebGLMultisampleRenderTarget.

* Exampels: Clean up.

* WebGLRenderer: Use multisampling when possible without reporting errors.

* Update WebGLRenderer.js

Co-authored-by: mrdoob <[email protected]>

* WebGLTextures: Fix depth textures with multisampling. (mrdoob#23611)

* WebGLRenderer: Fix setRenderTargetTextures(). (mrdoob#23644)

* fix transmission use multisample rtt error

* delete type definition of WebGLMultisampleRenderTarget

---------

Co-authored-by: Johnathon Selstad <[email protected]>
Co-authored-by: Michael Herzog <[email protected]>
Co-authored-by: mrdoob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values useRenderToTexture and __useRenderToTexture seems never be set
2 participants