WebGLRenderTarget: Clone depthTexture in copy() #23462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amodiopescefaro @ChaiGusto I'm not sure this solves the issue... |
|
Well, it sure seems like the right fix to me but https://jsfiddle.net/zhmoekwa/ still shows this:
I think that's a different issue. |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
RenaudRohlinger
added a commit
to RenaudRohlinger/three.js
that referenced
this pull request
Mar 24, 2022
…exture and depthTexture.clone Fixed MRT copy method: - texture[i] needed `isRenderTargetTexture = true` - Aligned the copy method of the depthTexture with WebGLRenderTarget (see mrdoob#23462)
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…exture and depthTexture.clone (mrdoob#23781) Fixed MRT copy method: - texture[i] needed `isRenderTargetTexture = true` - Aligned the copy method of the depthTexture with WebGLRenderTarget (see mrdoob#23462)
qiweicao
pushed a commit
to qiweicao/three.js
that referenced
this pull request
Apr 9, 2024
nianxy
pushed a commit
to qiweicao/three.js
that referenced
this pull request
Apr 10, 2024
nianxy
pushed a commit
to oppenfuture/three.js
that referenced
this pull request
Apr 10, 2024
* WebGLMultipleRenderTargets: Add Options to Constructor (mrdoob#22772) * WebGLMultipleRenderTargets: Add Options to Constructor * Update WebGLMultipleRenderTargets Documentation with new options * Add line break * WebGLMultipleRenderTargets: Use default parameter. Co-authored-by: Michael Herzog <[email protected]> * WebGLRenderTarget: Clone depthTexture in copy(). (mrdoob#23462) * Remove WebGLMultisampleRenderTarget. (mrdoob#23455) * Remove WebGLMultisampleRenderTarget. * THREE.Legacy.js: Add WebGLMultisampleRenderTarget. * Exampels: Clean up. * WebGLRenderer: Use multisampling when possible without reporting errors. * Update WebGLRenderer.js Co-authored-by: mrdoob <[email protected]> * WebGLTextures: Fix depth textures with multisampling. (mrdoob#23611) * WebGLRenderer: Fix setRenderTargetTextures(). (mrdoob#23644) * fix transmission use multisample rtt error * delete type definition of WebGLMultisampleRenderTarget --------- Co-authored-by: Johnathon Selstad <[email protected]> Co-authored-by: Michael Herzog <[email protected]> Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #22938
Description
See #22938 (comment)