Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLMultipleRenderTargets: Add Options to Constructor #22772

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

zalo
Copy link
Contributor

@zalo zalo commented Nov 1, 2021

This is a tiny PR which passes the options object through the constructor of WebGLMultipleRenderTargets.

This is necessary to initialize the render textures properly on mobile
(specifically, to get this GPGPU FEM Simulation working on iOS):
https://zalo.github.io/TetSim/

@mrdoob mrdoob added this to the r138 milestone Feb 8, 2022
@mrdoob mrdoob merged commit 680f6c9 into mrdoob:dev Feb 8, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 8, 2022

Thanks!

@zalo zalo deleted the fix-webglmultiplerendertargets-add-options branch February 8, 2022 19:57
0b5vr added a commit to 0b5vr/three-ts-types that referenced this pull request Mar 1, 2022
joshuaellis pushed a commit to three-types/three-ts-types that referenced this pull request Mar 1, 2022
* change (WebGLMultipleRenderTargets): Add Options to Constructor

See: mrdoob/three.js#22772

* refactor (WebGLMultipleRenderTargets): fix a lint issue
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* WebGLMultipleRenderTargets: Add Options to Constructor

* Update WebGLMultipleRenderTargets Documentation with new options

* Add line break

* WebGLMultipleRenderTargets: Use default parameter.

Co-authored-by: Michael Herzog <[email protected]>
qiweicao pushed a commit to qiweicao/three.js that referenced this pull request Apr 9, 2024
* WebGLMultipleRenderTargets: Add Options to Constructor

* Update WebGLMultipleRenderTargets Documentation with new options

* Add line break

* WebGLMultipleRenderTargets: Use default parameter.

Co-authored-by: Michael Herzog <[email protected]>
nianxy pushed a commit to qiweicao/three.js that referenced this pull request Apr 10, 2024
* WebGLMultipleRenderTargets: Add Options to Constructor

* Update WebGLMultipleRenderTargets Documentation with new options

* Add line break

* WebGLMultipleRenderTargets: Use default parameter.

Co-authored-by: Michael Herzog <[email protected]>
nianxy pushed a commit to oppenfuture/three.js that referenced this pull request Apr 10, 2024
* WebGLMultipleRenderTargets: Add Options to Constructor (mrdoob#22772)

* WebGLMultipleRenderTargets: Add Options to Constructor

* Update WebGLMultipleRenderTargets Documentation with new options

* Add line break

* WebGLMultipleRenderTargets: Use default parameter.

Co-authored-by: Michael Herzog <[email protected]>

* WebGLRenderTarget: Clone depthTexture in copy(). (mrdoob#23462)

* Remove WebGLMultisampleRenderTarget. (mrdoob#23455)

* Remove WebGLMultisampleRenderTarget.

* THREE.Legacy.js: Add WebGLMultisampleRenderTarget.

* Exampels: Clean up.

* WebGLRenderer: Use multisampling when possible without reporting errors.

* Update WebGLRenderer.js

Co-authored-by: mrdoob <[email protected]>

* WebGLTextures: Fix depth textures with multisampling. (mrdoob#23611)

* WebGLRenderer: Fix setRenderTargetTextures(). (mrdoob#23644)

* fix transmission use multisample rtt error

* delete type definition of WebGLMultisampleRenderTarget

---------

Co-authored-by: Johnathon Selstad <[email protected]>
Co-authored-by: Michael Herzog <[email protected]>
Co-authored-by: mrdoob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants