refactor: Identity - Vue Composition API

[preschian]

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• PR closes Refactor: Identity component - migrate to vue composition api #3749
• branching from refactor: move identity and identitypopover to one folder #3748. still WIP, can continue after that PR merged
• disable hover on mobile

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged the recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
• I've tested PR on mobile and everything seems works
• I found edge cases
• I've written some unit tests 🧪

Community participation

• Are you at KodaDot Discord?

Screenshot

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

WARNING @preschian PR for issue #3749 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3749

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	ea15a54
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/630897b8d0419c0008acb59a
😎 Deploy Preview	https://deploy-preview-3771--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

Shouldn't we need to move useIdentityStats.ts & useIdentity.ts into composables directory too?

And composables content seems to be auto imported in Nuxt, I don't think we need to declare them in file

edit: ref composables

[preschian]

And composables content seems to be auto imported in Nuxt, I don't think we need to declare them in file

TIL that nuxt will regenerate .nuxt/auto-imports.d.ts for composables folder 👍

Shouldn't we need to move useIdentityStats.ts & useIdentity.ts into composables directory too?

hhmm, I'm not sure and don't have a strong opinion to move that also. because those files are only used by components under the identity folder

[preschian]

btw, any feedback for this PR?

[roiLeo]

Nothing strange, code lgtm
Is it Ok to remove inline & no-overflow props?

edit: missing some translations :/

[preschian]

Nothing strange, code lgtm Is it Ok to remove inline & no-overflow props?

sure about no-overflow props, because unused. even a typo in the old component defines that props as noOwerflow. for inline, I skimmed almost all pages related to Identity seem fine, I couldn't find any styling issue

[yangwao]

LGTM

[codeclimate]

Code Climate has analyzed commit ea15a54 and detected 0 issues on this pull request.

View more on Code Climate.