Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move identity and identitypopover to one folder #3748

Merged
merged 24 commits into from
Aug 18, 2022

Conversation

preschian
Copy link
Member

@preschian preschian commented Aug 16, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes Refactor: Identity component #3747
  • move Identity and IdentityPopover into one folder
  • split Identity and IdentityPopover into smaller components
  • the rest of components only fix the eslint rules

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged the recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 355ccc1
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fe2ff190ba05000942d47a
😎 Deploy Preview https://deploy-preview-3748--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 16, 2022 19:42
@preschian preschian requested review from a team as code owners August 16, 2022 19:42
@preschian preschian requested review from roiLeo and DeluneClaire and removed request for a team August 16, 2022 19:42
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty nice, I was used to camelCase for props but you are right. ref vuejs style guide

I don't think we should keep scoped css in Identity components since they are unique class names

components/shared/identity/popover/IdentityPopover.vue Outdated Show resolved Hide resolved
pages/statemine/u/_id.vue Outdated Show resolved Hide resolved
components/shared/identity/popover/IdentityPopover.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 17, 2022
@petersopko
Copy link
Contributor

nice! tried identity popover throughout the app, all seems to be working well 😄

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 18, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 18, 2022

Code Climate has analyzed commit 355ccc1 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko enabled auto-merge August 18, 2022 12:29
@petersopko petersopko merged commit af7fbfe into kodadot:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Refactor: Identity component
3 participants