-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move identity and identitypopover to one folder #3748
refactor: move identity and identitypopover to one folder #3748
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty nice, I was used to camelCase for props but you are right. ref vuejs style guide
I don't think we should keep scoped
css in Identity components since they are unique class names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ code lgtm
…-move-identity-component
nice! tried identity popover throughout the app, all seems to be working well 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm
Code Climate has analyzed commit 355ccc1 and detected 0 issues on this pull request. View more on Code Climate. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Identity
andIdentityPopover
into one folderIdentity
andIdentityPopover
into smaller componentsBefore submitting Pull Request, please make sure:
Optional
Community participation
Screenshot