Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Curated List - Vue Composition API #3825

Merged
merged 8 commits into from
Sep 2, 2022
Merged

refactor: Curated List - Vue Composition API #3825

merged 8 commits into from
Sep 2, 2022

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 24, 2022

SUCCESS @preschian PR for issue #3772 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 24, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9f01c5b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63119c244b5edb00092ccb78
😎 Deploy Preview https://deploy-preview-3825--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 30, 2022 05:30
@preschian preschian requested review from a team as code owners August 30, 2022 05:30
@preschian preschian requested review from kkukelka, damskyftw and petersopko and removed request for a team August 30, 2022 05:30
@petersopko
Copy link
Contributor

wfm 🚀

petersopko
petersopko approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 1, 2022
kkukelka
kkukelka suggested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tiny things 😅

pages/snek/create.vue Outdated Show resolved Hide resolved
components/landing/CuratedList.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Sep 2, 2022

Code Climate has analyzed commit 9f01c5b and detected 0 issues on this pull request.

View more on Code Climate.

kkukelka
kkukelka approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@kkukelka kkukelka merged commit 87d2a95 into kodadot:main Sep 2, 2022
@kkukelka
Copy link
Member

kkukelka commented Sep 2, 2022

@preschian whats the payment range for this, i cannot tell from the linked tickets

@petersopko petersopko added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 2, 2022
@roiLeo roiLeo mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@petersopko petersopko petersopko approved these changes

@kkukelka kkukelka kkukelka approved these changes

@damskyftw damskyftw Awaiting requested review from damskyftw damskyftw was automatically assigned from kodadot/qa-guild

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Curated List - Vue Composition API
4 participants
@preschian @kodabot @petersopko @kkukelka