refactor: move media from rmrk/Media/ to media/

[preschian]

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• Refactor: landing page #3714
• setup vue composition API in nuxt-bridge
• move rmrk/Media/ to media/
• setup plugin with nuxt new syntax
• for development use nitro, for generate still using the old one bridge run generate, no dist directory generated nuxt/bridge#31 (comment)
• set sort-imports
• remove :mimeType="type" in components/rmrk/Gallery/GalleryCard.vue causing error logs in local only
• PR Closes fix(kit): avoid behavior change based on NODE_ENV nuxt/framework#3751

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged the recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Link Preview

Type	Link
Image	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/gallery/13438802-3892e43e923e5ad973-KAG-MINE_17-0000000000000457
3D	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/gallery/11380735-629a449743cd29bf21-3DGINO-YGGDRASIL-0000000000000041
Audio	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/gallery/11996182-ee8d75dede329d1224-SKMP-18_WHOLE_EPISODE_WITH_JARED_NATIONS-0000000000000058
Video	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/gallery/12049607-4466b2edfa4d261069-POLKAWEAR-YOROI_GIFT_CARD_15-0000000000000023
Landing page	https://deploy-preview-3718--koda-nuxt.netlify.app/
Collections	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/explore
Gallery	https://deploy-preview-3718--koda-nuxt.netlify.app/rmrk/explore?tab=GALLERY&page=1

Community participation

• Are you at KodaDot Discord?

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	4de15a3
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62fb9b16578c18000977d4cb
😎 Deploy Preview	https://deploy-preview-3718--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[petersopko]

@vikiival can I get your pair of 👀 at this?

[vikiival]

Pls maintain the order of the SFC

https://vuejs.org/api/sfc-spec.html#overview

[vikiival]

Isn't it better to use

import { defineProps } from 'vue'

than

import { defineProps } from '#app'

asking tbh

[vikiival]

Hey please maintain the order of the SFC - otherwise it's really hard to do the Code Review

[preschian]

Hey please maintain the order of the SFC - otherwise it's really hard to do the Code Review

oops sorry, will update

Isn't it better to use
import { defineProps } from 'vue'

there are some nuxt-specific, for example, useNuxtApp
but, when I peek at their ./.nuxt/tsconfig.json, they have another alternative. which one do you prefer?

import { useNuxtApp } from '#app'
import { useNuxtApp } from 'nuxt3/app'
import { useNuxtApp } from 'nuxt/app'

btw, I forgot to remove defineProps. no need to import https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits

[preschian]

Nice update, now auto imports don't throw errors anymore.

Last thing, It seems that I can't run linter anymore: pnpm run lint

throw:

Oops! Something went wrong! :(

ESLint: 8.21.0

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "...../nft-gallery/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help[](https://eslint.org/chat/help) to chat with the team.

works well when I remove 'prettier' from extends in .eslintrc config file

oh, try to run pnpm install first

[roiLeo]

oh, try to run pnpm install first

^ this, logical knowing that CI had no error

[vikiival]

Smol stuff.

Also I do not understand why you deleted old components :)
For the next time:

• mv to new location
• rename (if needed)
• refactor

This way we lost a lot of info 🥲

[preschian]

Smol stuff.

Also I do not understand why you deleted old components :) For the next time:

• mv to new location
• rename (if needed)
• refactor

This way we lost a lot of info 🥲

oops, tbh I'm curious about that also. afaik I moved the files, but let me try to re-moved that files again from the suggested steps 🙏🏻

update:
when I moved the files, GitHub was able to detect moved files as File renamed without changes.. but, when I changed it to use composition API in a different commit, git was not able to detect moved files. seems like GitHub has a kind of threshold diff https://stackoverflow.com/a/433142

I tried with git mv not work also. next, if I get this again better to move the files only. open different PR for refactor to composition API

[yangwao]

Added nuxt/framework#3751 to desc as it's fixing stuff 😄

[codeclimate]

Code Climate has analyzed commit 4de15a3 and detected 0 issues on this pull request.

View more on Code Climate.

[yangwao]

Tests are failing 😰

[preschian]

Tests are failing 😰

let me retry the pipeline again, I got the same error also previously. it works after retrying

[preschian]

Tests are failing 😰

this is the details regarding the test "sometimes" failing #3755

[yangwao]

okay let's try

[yangwao]

seems everything builds well