-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AvailableAction.vue - Unit Test #3738
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! :) Sure no problem, just added a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ code lgtm
Looks like code only, so i will just approve this right? |
Code Climate has analyzed commit 0acf958 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
tests are passing for me, maybe let's resolve conflicts, update from main and lfg :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm
@cazarov can you check out the DeepSource warnings please? |
pay 50 usd |
pay 50 |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
AvailableAction.vue
(and other components) by adding the new development dependency@rollup/plugin-graphql
and by refactoring the wallet configuration files to use ES6 imports.fake-indexeddb
as it is required to makeAvailableAction.vue
work in the non-browserjsdom
environment used for unit testing which does not have an IndexedDB implemention by default. To not slow down non-component file unit testing, I chose not to add loading it tovitest.config.js
.AvailableAction.vue
that check correct button type rendering based on props. More work is needed for proper unit test coverage for this component.Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot