Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvailableAction.vue - Unit Test #3738

Merged
merged 11 commits into from
Aug 16, 2022
Merged

AvailableAction.vue - Unit Test #3738

merged 11 commits into from
Aug 16, 2022

Conversation

cazarov
Copy link
Contributor

@cazarov cazarov commented Aug 15, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring
  • Tests

What's new?

  • PR closes AvailableAction.vue - Unit Test #2964
  • I have fixed the import errors that were blocking unit testing AvailableAction.vue (and other components) by adding the new development dependency @rollup/plugin-graphql and by refactoring the wallet configuration files to use ES6 imports.
  • I have added the new development dependency fake-indexeddb as it is required to make AvailableAction.vue work in the non-browser jsdom environment used for unit testing which does not have an IndexedDB implemention by default. To not slow down non-component file unit testing, I chose not to add loading it to vitest.config.js.
  • As a starting point, I have added three unit tests for AvailableAction.vue that check correct button type rendering based on props. More work is needed for proper unit test coverage for this component.

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@cazarov cazarov requested review from a team as code owners August 15, 2022 20:12
@cazarov cazarov requested review from roiLeo and DeluneClaire and removed request for a team August 15, 2022 20:12
@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit be2a1b4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fbc2fab059410008079340
😎 Deploy Preview https://deploy-preview-3738--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! would you mind changing logo name with something more meaningfull (CloverLogo, LedgerLogo, NovaLogo ...)

Tests pass
Capture d’écran 2022-08-15 à 10 48 50 PM

@cazarov
Copy link
Contributor Author

cazarov commented Aug 15, 2022

Hey! would you mind changing logo name with something more meaningfull (CloverLogo, LedgerLogo, NovaLogo ...)

Hi! :) Sure no problem, just added a commit.

@cazarov cazarov requested a review from roiLeo August 15, 2022 21:04
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@DeluneClaire
Copy link

Looks like code only, so i will just approve this right?

@codeclimate
Copy link

codeclimate bot commented Aug 16, 2022

Code Climate has analyzed commit 0acf958 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 7

View more on Code Climate.

@petersopko
Copy link
Contributor

tests are passing for me, maybe let's resolve conflicts, update from main and lfg :)

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 16, 2022
@petersopko
Copy link
Contributor

✅ code lgtm

👀
image

@petersopko petersopko added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 16, 2022
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@petersopko
Copy link
Contributor

@cazarov can you check out the DeepSource warnings please?

@cazarov
Copy link
Contributor Author

cazarov commented Aug 16, 2022

@cazarov can you check out the DeepSource warnings please?

All fixed, was just sort-imports after the rule got added in #3718.

@petersopko petersopko merged commit 9ac5109 into kodadot:main Aug 16, 2022
@petersopko
Copy link
Contributor

pay 50 usd

@cazarov cazarov deleted the available-action-unit-test branch August 16, 2022 16:46
@yangwao
Copy link
Member

yangwao commented Aug 17, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Aug 17, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 54.61 USD/KSM ~ 0.916 $KSM
🧗 J98SRy9JBahuoKgBUsTcLT3oYofoDj82fsWBsT9CaXBAmWb
🔗 0x98c0ce2462fd18efa627dc8440e87f6d3d2d1760477580a072e376395f81d5d4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

AvailableAction.vue - Unit Test
5 participants