This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(kit): avoid behavior change based on NODE_ENV #3751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#13399
related #3693 (comment)
β Type of change
π Description
If NODE_ENV is set to anything other than
development
,nuxi dev
will build for production! This issue was because we weren't settingdev
override and nuxt falling back to std-env to detect it.As to fix the root-cause, kit purely depends on C12 config types to avoid creating confusing interfaces that made this issue happen.
Options of
loadNuxt
changes (rootDir => cwd, config => overides) but preserved as backward compatibility.π Checklist