Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gax(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testBlockingServerStreaming - IllegalArgumentException #2107

Closed
github-actions bot opened this issue Oct 12, 2023 · 0 comments · Fixed by #2432
Closed

gax(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testBlockingServerStreaming - IllegalArgumentException #2107

github-actions bot opened this issue Oct 12, 2023 · 0 comments · Fixed by #2432
Assignees
@meltsufin
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited by burkedavison
Loading

The build has failed : https://github.com/googleapis/gapic-generator-java/actions/runs/6490063153

Error:  Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.863 s <<< FAILURE! -- in com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest
Error:  com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testBlockingServerStreaming -- Time elapsed: 0.047 s <<< ERROR!
com.google.api.gax.rpc.UnknownException: java.lang.IllegalArgumentException
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:119)
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41)
	at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.create(HttpJsonApiExceptionFactory.java:67)
	at com.google.api.gax.httpjson.HttpJsonExceptionResponseObserver.onErrorImpl(HttpJsonExceptionResponseObserver.java:82)
	at com.google.api.gax.rpc.StateCheckingResponseObserver.onError(StateCheckingResponseObserver.java:84)
	at com.google.api.gax.httpjson.HttpJsonDirectStreamController$ResponseObserverAdapter.onClose(HttpJsonDirectStreamController.java:125)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl$OnCloseNotificationTask.call(HttpJsonClientCallImpl.java:530)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.notifyListeners(HttpJsonClientCallImpl.java:379)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.deliver(HttpJsonClientCallImpl.java:306)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.setResult(HttpJsonClientCallImpl.java:156)
	at com.google.api.gax.httpjson.HttpRequestRunnable.run(HttpRequestRunnable.java:149)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
	Suppressed: java.lang.RuntimeException: Asynchronous task failed
		at com.google.api.gax.rpc.ServerStreamIterator.hasNext(ServerStreamIterator.java:105)
		at com.google.common.collect.Iterators.addAll(Iterators.java:366)
		at com.google.common.collect.Lists.newArrayList(Lists.java:146)
		at com.google.common.collect.Lists.newArrayList(Lists.java:132)
		at com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testBlockingServerStreaming(HttpJsonDirectServerStreamingCallableTest.java:328)
		at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
		at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
		at java.lang.reflect.Method.invoke(Method.java:498)
		at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
		at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
		at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
		at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
		at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
		at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
		at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
		at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
		at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
		at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
		at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
		at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
		at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
		at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
		at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
		at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
		at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
		at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
		at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
		at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
		at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
		at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
		at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
		at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
		at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
		at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
		at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:[495](https://github.com/googleapis/sdk-platform-java/actions/runs/6490063153/job/17625302647#step:9:496))
Caused by: java.lang.IllegalArgumentException
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:129)
	at com.google.api.gax.httpjson.testing.MockHttpService.getHttpResponse(MockHttpService.java:131)
	at com.google.api.gax.httpjson.testing.MockHttpService.access$100(MockHttpService.java:60)
	at com.google.api.gax.httpjson.testing.MockHttpService$MockHttpRequest.execute(MockHttpService.java:164)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1012)
	at com.google.api.gax.httpjson.HttpRequestRunnable.run(HttpRequestRunnable.java:115)
	... 3 more
@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 12, 2023
@burkedavison burkedavison changed the title Nightly-java8 build on windows-2022 failed. gax(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testBlockingServerStreaming - IllegalArgumentException Oct 24, 2023
@blakeli0 blakeli0 mentioned this issue Nov 3, 2023
Closed
@suztomo suztomo added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 23, 2024
@meltsufin meltsufin self-assigned this Jan 31, 2024
meltsufin added a commit that referenced this issue Jan 31, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest
342467d 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1842.
Fixes: #1587.
Fixes: #1684.
@meltsufin meltsufin mentioned this issue Jan 31, 2024
Merged
meltsufin added a commit that referenced this issue Feb 6, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest (#2432)
523d6b6 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1587.
Fixes: #1684.
ddixit14 pushed a commit that referenced this issue Feb 15, 2024
@meltsufin @ddixit14
test: fix flakes in HttpJsonDirectServerStreamingCallableTest (#2432)
58d2cc3 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1587.
Fixes: #1684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flakes in HttpJsonDirectServerStreamingCallableTest googleapis/sdk-platform-java
3 participants
@suztomo @meltsufin @burkedavison