Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky HttpJsonDirectServerStreamingCallableTest.testServerStreaming #1587

Closed
mpeddada1 opened this issue Mar 30, 2023 · 4 comments · Fixed by #2432
Closed

Flaky HttpJsonDirectServerStreamingCallableTest.testServerStreaming #1587

mpeddada1 opened this issue Mar 30, 2023 · 4 comments · Fixed by #2432
Assignees
@meltsufin
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mpeddada1
Copy link
Contributor

Github Actions Link: https://github.com/googleapis/gapic-generator-java/actions/runs/4557244051/jobs/8038623360?pr=1582
Stacktrace:

Error:  Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.102 s <<< FAILURE! - in com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest
Error:  com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testServerStreaming  Time elapsed: 10.055 s  <<< FAILURE!
value of: await(...)
expected to be true
	at com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testServerStreaming(HttpJsonDirectServerStreamingCallableTest.java:211)
@mpeddada1 mpeddada1 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 30, 2023
@lqiu96 lqiu96 self-assigned this Apr 24, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented May 8, 2023

Ran this with 60k invocations and wasn't able to reproduce this issue. Closing for now and we can re-open if this flakes again.

@lqiu96 lqiu96 closed this as completed May 8, 2023
@emmileaf
Copy link
Contributor

This issue is re-opened in #1587.

@meltsufin
Copy link
Member

meltsufin commented Jan 10, 2024 •
edited
Loading

It's still an issue: https://github.com/googleapis/sdk-platform-java/actions/runs/7469110637/job/20325696231
#2352

@meltsufin meltsufin reopened this Jan 10, 2024
@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 11, 2024
@alicejli
Copy link
Contributor

Failed on Jan 23 (Nightly build for Java 17 on windows-2022 failed): #2413

@alicejli alicejli mentioned this issue Jan 30, 2024
Closed
@meltsufin meltsufin assigned meltsufin and unassigned lqiu96 Jan 31, 2024
meltsufin added a commit that referenced this issue Jan 31, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest
342467d 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1842.
Fixes: #1587.
Fixes: #1684.
@meltsufin meltsufin mentioned this issue Jan 31, 2024
Merged
ddixit14 pushed a commit that referenced this issue Feb 15, 2024
@meltsufin @ddixit14
test: fix flakes in HttpJsonDirectServerStreamingCallableTest (#2432)
58d2cc3 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1587.
Fixes: #1684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flakes in HttpJsonDirectServerStreamingCallableTest googleapis/sdk-platform-java
5 participants
@lqiu96 @emmileaf @meltsufin @alicejli @mpeddada1