Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testManualFlowControl #1684

Closed
github-actions bot opened this issue May 16, 2023 · 2 comments · Fixed by #2432
Closed

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testManualFlowControl #1684

github-actions bot opened this issue May 16, 2023 · 2 comments · Fixed by #2432
Assignees
@meltsufin
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@github-actions
Copy link

The build has failed : https://github.com/googleapis/gapic-generator-java/actions/runs/4986876999
@burkedavison
Copy link
Member 

Error: Exception in thread "Thread-12" io.grpc.StatusRuntimeException: CANCELLED: call already cancelled. Use ServerCallStreamObserver.setOnCancelHandler() to disable this exception
	at io.grpc.Status.asRuntimeException(Status.java:530)
	at io.grpc.stub.ServerCalls$ServerCallStreamObserverImpl.onNext(ServerCalls.java:366)
	at com.google.api.gax.grpc.testing.FakeServiceImpl$2.run(FakeServiceImpl.java:93)
	at java.base/java.lang.Thread.run(Thread.java:829)

Error:  com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testManualFlowControl  Time elapsed: 3.33 s  <<< FAILURE!
value of: await(...)
expected to be true
	at com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testManualFlowControl(HttpJsonDirectServerStreamingCallableTest.java:237)

@burkedavison burkedavison changed the title Nightly build for Java 11 on windows-2022 failed. gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testManualFlowControl May 16, 2023
@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 16, 2023
This was referenced Jun 5, 2023
Closed
Closed
Closed
@lqiu96 lqiu96 mentioned this issue Jun 27, 2023
Closed
This was referenced Jul 4, 2023
Closed
Closed
Closed
This was referenced Aug 2, 2023
Closed
Closed
@meltsufin meltsufin added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 10, 2023
@suztomo suztomo mentioned this issue Aug 31, 2023
Closed
@mpeddada1 mpeddada1 self-assigned this Sep 13, 2023
@mpeddada1
Copy link
Contributor

mpeddada1 commented Oct 17, 2023 •
edited
Loading

  • The test passes on Linux (executed ~700 times):
Screenshot 2023-10-17 at 3 49 04 PM

@lqiu96 lqiu96 mentioned this issue Nov 28, 2023
Closed
@meltsufin meltsufin assigned meltsufin and unassigned mpeddada1 Jan 31, 2024
meltsufin added a commit that referenced this issue Jan 31, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest
342467d 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1842.
Fixes: #1587.
Fixes: #1684.
@meltsufin meltsufin mentioned this issue Jan 31, 2024
Merged
ddixit14 pushed a commit that referenced this issue Feb 15, 2024
@meltsufin @ddixit14
test: fix flakes in HttpJsonDirectServerStreamingCallableTest (#2432)
58d2cc3 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1587.
Fixes: #1684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flakes in HttpJsonDirectServerStreamingCallableTest googleapis/sdk-platform-java
3 participants
@meltsufin @burkedavison @mpeddada1