Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError - value of await() #2083

Closed
burkedavison opened this issue Oct 10, 2023 · 0 comments · Fixed by #2432
Closed

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError - value of await() #2083

burkedavison opened this issue Oct 10, 2023 · 0 comments · Fixed by #2432
Assignees
@meltsufin
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@burkedavison
Copy link
Member

https://github.com/googleapis/sdk-platform-java/actions/runs/6463556602/job/17546900656

Error:  Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.74 s <<< FAILURE! -- in com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest
Error:  com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testOnResponseError -- Time elapsed: 3.264 s <<< FAILURE!
value of: await(...)
expected to be true
	at com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testOnResponseError(HttpJsonDirectServerStreamingCallableTest.java:266)
@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 10, 2023
@burkedavison burkedavison mentioned this issue Oct 10, 2023
Closed
@suztomo suztomo mentioned this issue Oct 27, 2023
Closed
@lqiu96 lqiu96 mentioned this issue Nov 27, 2023
Closed
@mpeddada1 mpeddada1 mentioned this issue Dec 14, 2023
Closed
@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2024
@meltsufin meltsufin self-assigned this Jan 31, 2024
meltsufin added a commit that referenced this issue Jan 31, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest
342467d 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1842.
Fixes: #1587.
Fixes: #1684.
@meltsufin meltsufin mentioned this issue Jan 31, 2024
Merged
ddixit14 pushed a commit that referenced this issue Feb 15, 2024
@meltsufin @ddixit14
test: fix flakes in HttpJsonDirectServerStreamingCallableTest (#2432)
58d2cc3 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1587.
Fixes: #1684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flakes in HttpJsonDirectServerStreamingCallableTest googleapis/sdk-platform-java
2 participants
@meltsufin @burkedavison