Add looking for a team option to projects form #6348

zoek1 · 2020-04-01T01:47:40Z

Description

Add option and input to indicate the user is looking for team members
Add one image field add one banner to hackathons
remove discord from project form

Refers/Fixes

No issue

Testing

octavioamu

left some comments Zoek

octavioamu · 2020-04-01T04:37:20Z

app/dashboard/views.py

@@ -3939,24 +3943,24 @@ def hackathon_save_project(request):
                'logo': request.FILES.get('logo', project.first().logo)
            })

-            project.update(**kwargs)
+            # project.update(**kwargs)


the code doesn't need to update the project?

octavioamu · 2020-04-01T04:37:50Z

app/dashboard/views.py

-                bounty_profile = Profile.objects.get(handle=project.bounty.bounty_owner_github_username.lower())
-                if bounty_profile.chat_id is '' or bounty_profile.chat_id is None:
-                    created, bounty_profile = associate_chat_to_profile(bounty_profile)
+            #try:


we are removing the chat associated actions?

Thanks, i thought i restored these lines. The chat related actions caused crash my environment so i commented this piece of code.

@zoek1 there are some docs for the Gitcoin Chat setup, the container will spin up automatically.

If you go through that setup then you'll stop getting any connection issues.

Thanks @androolloyd, I'll check it later today!

codecov · 2020-04-01T05:13:20Z

Codecov Report

Merging #6348 into master will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #6348      +/-   ##
==========================================
+ Coverage   27.56%   27.59%   +0.02%     
==========================================
  Files         282      282              
  Lines       26148    26153       +5     
  Branches     3850     3850              
==========================================
+ Hits         7208     7217       +9     
+ Misses      18675    18671       -4     
  Partials      265      265

Impacted Files	Coverage Δ
app/dashboard/views.py	`11.20% <0.00%> (-0.01%)`	⬇️
app/dashboard/models.py	`49.78% <100.00%> (+0.05%)`	⬆️
app/dashboard/embed.py	`31.60% <0.00%> (+3.44%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff44910...8f17135. Read the comment docs.

octavioamu

Thanks zoek

danlipert

One small question about message limit - also, please squash the migrations, thanks!

danlipert · 2020-04-01T14:06:11Z

app/dashboard/models.py

@@ -4668,6 +4669,12 @@ class HackathonProject(SuperModel):
        choices=PROJECT_STATUS,
        blank=True
    )
+    message = models.CharField(
+        max_length=150,


I'm wondering if this limit is too short, what do you think?

i think is ok for a short message, originally the tweets have a length of 140 characters and worked well. One example could be:

Hi! I'm python developer and I'm looking for a fronted partner to hack on the ETC bounty "Create A DIY Hardware Wallet Using Signatory"

150 character limit will help to synthesize messages, and having a character count helper will help a lot the user. What do you think @PixelantDesign?

…into feature/looking-team

PixelantDesign · 2020-04-06T12:33:17Z

check it out ^ @alexvotofuture hopefully this helps with what we talked about last week!

* Add option to looking for team members * Add banner for hackathons * Restored commented chat functionality on hackathon projects * Squash migrations on dashboard * Remove discord from project form Co-authored-by: Dan Lipert <[email protected]>

* Add base template for request money * Fill tip based on request fund * Fix update of requests * avatar text injection opacity * filter out new github profiles * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * less sleep time between iteratings * enables visibility filter on /hackathons * updates stats view * cache for an hour, make stats GA * walle and chappie * active subscriptoins link * robots.txt for kudos redemptoin links * fix for wall posts * raw ids on phantom funds * better caching architecture for the grants stats page * fix for extremely strange stats page bug where chrome renders the iframe over top of the rest of the page, by inserting the iframe 100ms after page load * fixes the caching scheme, and does a quick responsive design fix * fixes the CLR contribution pks to be passed into a queryst * troubleshooting docker and mac high cpu usage Updates with one troubleshooting tip for problems with high CPU usage on mac while installing with docker and links to issues on this topic from docker's for mac repo. * Add prizes header and hero * fix bounty details with old cross-chain bounties 0 stdbounties id * use redirect for 0 std bounties id * Adds twitter handle support on gitcoin profile handles Fixes an issue with grants contract owner address Fixes a grant gas price issue. fixes an issue with payout of mini clrs where some users were duplciated * stats for clr * handles condition in which no txid is broadcast in mini clr payout * combines activity and description tabs * fixes gitcoinco#6322 (comment) * Change layout for hackathon projects * bug: show categories even when grant has none * fix/disable tests (ddt) * - adds a admin comment field on actions for connnor - updates format of dead grant mail - adds script to check for grant contribution IP addresses to check for sybil attack * ability to copy + schedule offer * schedule offer copy * hide overlay when you show the tweet modal * Revert "hide overlay when you show the tweet modal" This reverts commit 9643fb4. * Revert "Revert "hide overlay when you show the tweet modal"" This reverts commit 7f1ef93. * changes the scope of the form_disabled method * next round start date * grants round end time now moved to 5pm MST * escape charset * Fix serialization of grants for REST API * Update sidebar_search_hackathon.html * Favorite a post on town square (gitcoinco#6181) * Add favorite functionality * fix eslint * Update views.py * fix migrations Co-authored-by: Dan Lipert <[email protected]> * Add tribes to townsquare (gitcoinco#6290) * Add tribes to townsquare * Fix padding and mergin of buttons * Change button style to fit CLR style button Co-authored-by: Dan Lipert <[email protected]> * fix stylelint * One Click Fund Issue Link In Townsquare (gitcoinco#6156) * Allow fund issue from posts with one issue on its content * Fix lint Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: Dan Lipert <[email protected]> * puts searchresults objects in elasticsearch/ makes search GA (gitcoinco#6340) * POC * puts documents in elasticsearch * make fix * fix typos Co-authored-by: Dan Lipert <[email protected]> * fix favorite view props * new wallee avatar by virtual-face * better fix for view props * kudos PKs, removes the lambo one * respect the mint to address of the token * fix favorites and sidebar * fix unfavorite * Fix serialization of grants for REST API * adds chappie avatar * fixes the kudos 1. rendering in frontend 2. allowing URL to be attached to token request 3. now sends an email after that kudos is minted * fixes the countdown field in all our celery retries * exponential backoff for kudos redemption * changes celery multiplier to be smarter * hotfix that makes kudos celery redemptions actually work reliably * Typo correction that was breaking instructions. There was an additional backtick breaking instructions on #### Docker for-mac troubleshooting section, and it has been corrected. * fix cross chain bounty creation std_bounties_id assignment * refactor: fixup listen_for_web3_changes * handle case in which gitcoinbot doesnt exist' * enable tipping on grants * Revert "Add hackathon prizes view and projects" * ads a new avatar * adds new iamthembot avatar * Revert "As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder." * updates avatar * Add looking for a team option to projects form (gitcoinco#6348) * Add option to looking for team members * Add banner for hackathons * Restored commented chat functionality on hackathon projects * Squash migrations on dashboard * Remove discord from project form Co-authored-by: Dan Lipert <[email protected]> * core: base commit for celo + zil + refactor (gitcoinco#6313) * core: base commit for celo + zil - update mgmt command to to cater for all cross-chain pending fulfillments - refactor and move all token specific logic to it's own file within sync/ - remove un-used url - update bounty creation to include celo * set fulfillments > 5 min as expired * add migration file * update API wiring for ZIL * update API wiring for celo * update bounty creation flow * bug: rename variable * celo: update to support cUSD and cGLD * fixup ZIL backend * recreate migration * bug: fix up celo * Update etc.py * fix migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove private bounties (gitcoinco#6305) * purge: remove private bounties - remove BountyDocuments Table - remove unsigned_nda/signed_nda fields from Bounty + Interest - remove private repo code in new bounty and bounty detail (vue + jquery) - updated Bounty serializer to remove BountyDocument and unsigned_nda - removed images which are not used - updated email removing private repo code - remove bounty document upload endpoint used for signd nda upload - remove private repo specific css - defaulted repo type to public from frontend * add migration + UI fixes * add merge migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove pricing + subscibe page (gitcoinco#6397) Co-authored-by: Dan Lipert <[email protected]> * bug: https://sentry.io/organizations/gitcoin/issues/1567040592 * chore: add sync_pendinf_fulfillments to cron (gitcoinco#6400) Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Miguel Angel G <[email protected]> Co-authored-by: owocki <[email protected]> Co-authored-by: federicosan <[email protected]> Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: octavioamu <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Kevin Owocki <[email protected]>

zoek1 added 2 commits March 31, 2020 17:46

Add option to looking for team members

699d6d8

Add banner for hackathons

21c3231

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners April 1, 2020 01:47

octavioamu suggested changes Apr 1, 2020

View reviewed changes

Restored commented chat functionality on hackathon projects

e4e1475

octavioamu approved these changes Apr 1, 2020

View reviewed changes

danlipert added 2 commits April 1, 2020 23:02

Merge branch 'master' into feature/looking-team

9c7a37f

Merge branch 'master' into feature/looking-team

9a8cc8f

danlipert suggested changes Apr 1, 2020

View reviewed changes

Squash migrations on dashboard

4984c4f

zoek1 requested a review from danlipert April 1, 2020 21:04

Merge branch 'master' into feature/looking-team

bdb9bf2

zoek1 mentioned this pull request Apr 3, 2020

Hackathon Project Flow: Project creation upon start work #6362

Closed

1 task

zoek1 added 2 commits April 3, 2020 01:18

Remove discord from project form

6e34c7c

Merge branch 'feature/looking-team' of https://github.com/zoek1/web-1 …

8b00a89

…into feature/looking-team

thelostone-mc approved these changes Apr 7, 2020

View reviewed changes

danlipert approved these changes Apr 7, 2020

View reviewed changes

Merge branch 'master' into feature/looking-team

8f17135

danlipert merged commit cee8e8f into gitcoinco:master Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add looking for a team option to projects form #6348

Add looking for a team option to projects form #6348

zoek1 commented Apr 1, 2020 •

edited

Loading

octavioamu left a comment

octavioamu Apr 1, 2020

octavioamu Apr 1, 2020

zoek1 Apr 1, 2020

androolloyd Apr 7, 2020

zoek1 Apr 8, 2020

codecov bot commented Apr 1, 2020 •

edited

Loading

octavioamu left a comment

danlipert left a comment

danlipert Apr 1, 2020

zoek1 Apr 1, 2020

PixelantDesign commented Apr 6, 2020

Add looking for a team option to projects form #6348

Add looking for a team option to projects form #6348

Conversation

zoek1 commented Apr 1, 2020 • edited Loading

Description

Refers/Fixes

Testing

octavioamu left a comment

Choose a reason for hiding this comment

octavioamu Apr 1, 2020

Choose a reason for hiding this comment

octavioamu Apr 1, 2020

Choose a reason for hiding this comment

zoek1 Apr 1, 2020

Choose a reason for hiding this comment

androolloyd Apr 7, 2020

Choose a reason for hiding this comment

zoek1 Apr 8, 2020

Choose a reason for hiding this comment

codecov bot commented Apr 1, 2020 • edited Loading

Codecov Report

octavioamu left a comment

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

danlipert Apr 1, 2020

Choose a reason for hiding this comment

zoek1 Apr 1, 2020

Choose a reason for hiding this comment

PixelantDesign commented Apr 6, 2020

zoek1 commented Apr 1, 2020 •

edited

Loading

codecov bot commented Apr 1, 2020 •

edited

Loading