core: base commit for celo + zil + refactor #6313

thelostone-mc · 2020-03-27T11:04:04Z

Description

update mgmt command to to cater for all cross-chain pending
fulfillments
refactor and move all token specific logic to it's own file
within sync/
remove un-used url
update bounty creation to include celo
set fulfillments > 5 min as expired

Refers/Fixes

NOTE

remove erc-20 ZIL from token

Decimals

ZIL: 12
cUSD: 18
cGLD: 18

codecov · 2020-03-30T20:12:22Z

Codecov Report

Merging #6313 into master will decrease coverage by 0.02%.
The diff coverage is 18.42%.

@@            Coverage Diff             @@
##           master    #6313      +/-   ##
==========================================
- Coverage   27.57%   27.55%   -0.03%     
==========================================
  Files         282      286       +4     
  Lines       26153    26257     +104     
  Branches     3850     3876      +26     
==========================================
+ Hits         7211     7234      +23     
- Misses      18677    18754      +77     
- Partials      265      269       +4

Impacted Files	Coverage Δ
app/app/urls.py	`86.44% <ø> (ø)`
.../dashboard/management/commands/sync_etc_payouts.py	`0.00% <0.00%> (ø)`
app/dashboard/models.py	`49.78% <ø> (ø)`
app/dashboard/views.py	`11.18% <0.00%> (-0.02%)`	⬇️
app/dashboard/sync/celo.py	`14.63% <14.63%> (ø)`
app/dashboard/sync/etc.py	`14.63% <14.63%> (ø)`
app/dashboard/sync/zil.py	`20.45% <20.45%> (ø)`
app/dashboard/utils.py	`43.70% <36.36%> (+1.99%)`	⬆️
app/dashboard/sync/helpers.py	`66.66% <66.66%> (ø)`
app/app/settings.py	`81.36% <100.00%> (+0.05%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee8e8f...96e5b3d. Read the comment docs.

- update mgmt command to to cater for all cross-chain pending fulfillments - refactor and move all token specific logic to it's own file within sync/ - remove un-used url - update bounty creation to include celo

octavioamu · 2020-04-08T04:28:44Z

app/app/urls.py

@@ -250,11 +250,6 @@
    re_path(r'^bounty/quickstart/?', dashboard.views.quickstart, name='quickstart'),
    url(r'^bounty/new/?', dashboard.views.new_bounty, name='new_bounty'),
    re_path(r'^bounty/change/(?P<bounty_id>.*)?', dashboard.views.change_bounty, name='change_bounty'),
-    url(


we don't need this one anymore?

octavioamu · 2020-04-08T04:29:34Z

app/assets/v2/js/pages/create_bounty/token.js

@@ -76,7 +76,7 @@ createBounty = data => {
    'eventTag': metadata.eventTag,
    'auto_approve_workers': data.auto_approve_workers ? 'True' : 'False',
    'web3_type': 'qr',
-    'activity': data.activity
+    'activity': data.activity,


octavioamu

lgtm

wizzfile

danlipert · 2020-04-08T13:10:19Z

@wizzfile what is that?

* Add base template for request money * Fill tip based on request fund * Fix update of requests * avatar text injection opacity * filter out new github profiles * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * less sleep time between iteratings * enables visibility filter on /hackathons * updates stats view * cache for an hour, make stats GA * walle and chappie * active subscriptoins link * robots.txt for kudos redemptoin links * fix for wall posts * raw ids on phantom funds * better caching architecture for the grants stats page * fix for extremely strange stats page bug where chrome renders the iframe over top of the rest of the page, by inserting the iframe 100ms after page load * fixes the caching scheme, and does a quick responsive design fix * fixes the CLR contribution pks to be passed into a queryst * troubleshooting docker and mac high cpu usage Updates with one troubleshooting tip for problems with high CPU usage on mac while installing with docker and links to issues on this topic from docker's for mac repo. * Add prizes header and hero * fix bounty details with old cross-chain bounties 0 stdbounties id * use redirect for 0 std bounties id * Adds twitter handle support on gitcoin profile handles Fixes an issue with grants contract owner address Fixes a grant gas price issue. fixes an issue with payout of mini clrs where some users were duplciated * stats for clr * handles condition in which no txid is broadcast in mini clr payout * combines activity and description tabs * fixes gitcoinco#6322 (comment) * Change layout for hackathon projects * bug: show categories even when grant has none * fix/disable tests (ddt) * - adds a admin comment field on actions for connnor - updates format of dead grant mail - adds script to check for grant contribution IP addresses to check for sybil attack * ability to copy + schedule offer * schedule offer copy * hide overlay when you show the tweet modal * Revert "hide overlay when you show the tweet modal" This reverts commit 9643fb4. * Revert "Revert "hide overlay when you show the tweet modal"" This reverts commit 7f1ef93. * changes the scope of the form_disabled method * next round start date * grants round end time now moved to 5pm MST * escape charset * Fix serialization of grants for REST API * Update sidebar_search_hackathon.html * Favorite a post on town square (gitcoinco#6181) * Add favorite functionality * fix eslint * Update views.py * fix migrations Co-authored-by: Dan Lipert <[email protected]> * Add tribes to townsquare (gitcoinco#6290) * Add tribes to townsquare * Fix padding and mergin of buttons * Change button style to fit CLR style button Co-authored-by: Dan Lipert <[email protected]> * fix stylelint * One Click Fund Issue Link In Townsquare (gitcoinco#6156) * Allow fund issue from posts with one issue on its content * Fix lint Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: Dan Lipert <[email protected]> * puts searchresults objects in elasticsearch/ makes search GA (gitcoinco#6340) * POC * puts documents in elasticsearch * make fix * fix typos Co-authored-by: Dan Lipert <[email protected]> * fix favorite view props * new wallee avatar by virtual-face * better fix for view props * kudos PKs, removes the lambo one * respect the mint to address of the token * fix favorites and sidebar * fix unfavorite * Fix serialization of grants for REST API * adds chappie avatar * fixes the kudos 1. rendering in frontend 2. allowing URL to be attached to token request 3. now sends an email after that kudos is minted * fixes the countdown field in all our celery retries * exponential backoff for kudos redemption * changes celery multiplier to be smarter * hotfix that makes kudos celery redemptions actually work reliably * Typo correction that was breaking instructions. There was an additional backtick breaking instructions on #### Docker for-mac troubleshooting section, and it has been corrected. * fix cross chain bounty creation std_bounties_id assignment * refactor: fixup listen_for_web3_changes * handle case in which gitcoinbot doesnt exist' * enable tipping on grants * Revert "Add hackathon prizes view and projects" * ads a new avatar * adds new iamthembot avatar * Revert "As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder." * updates avatar * Add looking for a team option to projects form (gitcoinco#6348) * Add option to looking for team members * Add banner for hackathons * Restored commented chat functionality on hackathon projects * Squash migrations on dashboard * Remove discord from project form Co-authored-by: Dan Lipert <[email protected]> * core: base commit for celo + zil + refactor (gitcoinco#6313) * core: base commit for celo + zil - update mgmt command to to cater for all cross-chain pending fulfillments - refactor and move all token specific logic to it's own file within sync/ - remove un-used url - update bounty creation to include celo * set fulfillments > 5 min as expired * add migration file * update API wiring for ZIL * update API wiring for celo * update bounty creation flow * bug: rename variable * celo: update to support cUSD and cGLD * fixup ZIL backend * recreate migration * bug: fix up celo * Update etc.py * fix migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove private bounties (gitcoinco#6305) * purge: remove private bounties - remove BountyDocuments Table - remove unsigned_nda/signed_nda fields from Bounty + Interest - remove private repo code in new bounty and bounty detail (vue + jquery) - updated Bounty serializer to remove BountyDocument and unsigned_nda - removed images which are not used - updated email removing private repo code - remove bounty document upload endpoint used for signd nda upload - remove private repo specific css - defaulted repo type to public from frontend * add migration + UI fixes * add merge migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove pricing + subscibe page (gitcoinco#6397) Co-authored-by: Dan Lipert <[email protected]> * bug: https://sentry.io/organizations/gitcoin/issues/1567040592 * chore: add sync_pendinf_fulfillments to cron (gitcoinco#6400) Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Miguel Angel G <[email protected]> Co-authored-by: owocki <[email protected]> Co-authored-by: federicosan <[email protected]> Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: octavioamu <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Kevin Owocki <[email protected]>

thelostone-mc force-pushed the celo branch from 4451629 to b9a94fc Compare March 28, 2020 11:06

thelostone-mc changed the title ~~core: base commit for celo~~ core: base commit for celo + zil + refactor Mar 28, 2020

thelostone-mc force-pushed the celo branch 4 times, most recently from 47f2dfd to 7dd16b2 Compare April 2, 2020 11:17

thelostone-mc added 7 commits April 2, 2020 21:36

core: base commit for celo + zil

0be9848

- update mgmt command to to cater for all cross-chain pending fulfillments - refactor and move all token specific logic to it's own file within sync/ - remove un-used url - update bounty creation to include celo

set fulfillments > 5 min as expired

463dfc1

add migration file

c8ad81d

update API wiring for ZIL

dd22544

update API wiring for celo

fd836e9

update bounty creation flow

aa8a0bc

bug: rename variable

ca4112c

thelostone-mc force-pushed the celo branch from c608f4a to 708416c Compare April 2, 2020 16:50

celo: update to support cUSD and cGLD

5bc84dd

thelostone-mc force-pushed the celo branch from 708416c to 5bc84dd Compare April 2, 2020 17:30

thelostone-mc added 3 commits April 3, 2020 14:40

fixup ZIL backend

4b32213

recreate migration

f37988e

bug: fix up celo

3a445e0

thelostone-mc marked this pull request as ready for review April 6, 2020 17:32

thelostone-mc requested review from danlipert and octavioamu as code owners April 6, 2020 17:32

Update etc.py

e82d9df

octavioamu reviewed Apr 8, 2020

View reviewed changes

octavioamu approved these changes Apr 8, 2020

View reviewed changes

danlipert approved these changes Apr 8, 2020

View reviewed changes

danlipert added 2 commits April 8, 2020 20:28

Merge branch 'master' into celo

2e0a97b

fix migration

96e5b3d

danlipert merged commit f1d43c2 into master Apr 8, 2020

wizzfile reviewed Apr 8, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: base commit for celo + zil + refactor #6313

core: base commit for celo + zil + refactor #6313

thelostone-mc commented Mar 27, 2020 •

edited

Loading

codecov bot commented Mar 30, 2020 •

edited

Loading

octavioamu Apr 8, 2020

octavioamu Apr 8, 2020

octavioamu left a comment

wizzfile left a comment

danlipert commented Apr 8, 2020

core: base commit for celo + zil + refactor #6313

core: base commit for celo + zil + refactor #6313

Conversation

thelostone-mc commented Mar 27, 2020 • edited Loading

Description

Refers/Fixes

NOTE

Decimals

codecov bot commented Mar 30, 2020 • edited Loading

Codecov Report

octavioamu Apr 8, 2020

Choose a reason for hiding this comment

octavioamu Apr 8, 2020

Choose a reason for hiding this comment

octavioamu left a comment

Choose a reason for hiding this comment

wizzfile left a comment

Choose a reason for hiding this comment

danlipert commented Apr 8, 2020

thelostone-mc commented Mar 27, 2020 •

edited

Loading

codecov bot commented Mar 30, 2020 •

edited

Loading