Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Click Fund Issue Link In Townsquare #6156

Merged
merged 7 commits into from
Apr 1, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Mar 5, 2020

Description
  • Anyone can one click fund an issue

  • If thread contains github link, display ability to fund that issue via menu
    image

  • Open fund issue in new tab with url pre-populated in the form
    DeepinScreenshot_20200305152705

  • Once the issue has been funded, show the comment in the original townsquare thread
    image

  • Post a video or screenshots for core team review

Refers/Fixes

#6149

Testing

https://www.dropbox.com/s/1dkc5ueas1qydt2/2020-03-09%2005-48-08.flv?dl=0

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but left a few minor comments

app/assets/v2/js/activity.js Outdated Show resolved Hide resolved
app/assets/v2/js/activity.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/new_bounty.js Outdated Show resolved Hide resolved
@@ -75,7 +75,8 @@ createBounty = data => {
'attached_job_description': hiring.jobDescription,
'eventTag': metadata.eventTag,
'auto_approve_workers': data.auto_approve_workers ? 'True' : 'False',
'web3_type': 'qr'
'web3_type': 'qr',
'activity': data.activity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice you've also covered for ETC

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #6156 into master will decrease coverage by <.01%.
The diff coverage is 3.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6156      +/-   ##
==========================================
- Coverage   27.61%   27.61%   -0.01%     
==========================================
  Files         281      281              
  Lines       26054    26083      +29     
  Branches     3841     3843       +2     
==========================================
+ Hits         7196     7203       +7     
- Misses      18594    18616      +22     
  Partials      264      264
Impacted Files Coverage Δ
app/retail/views.py 21.18% <0%> (-0.05%) ⬇️
app/dashboard/views.py 11.21% <3.57%> (-0.09%) ⬇️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fbfd6...01764e0. Read the comment docs.

@zoek1 zoek1 requested a review from thelostone-mc March 9, 2020 11:55
@zoek1
Copy link
Contributor Author

zoek1 commented Mar 27, 2020

@danlipert @thelostone-mc could i get your feedback on this please? 😄

@danlipert danlipert merged commit f750372 into gitcoinco:master Apr 1, 2020
wizzfile added a commit to wizzfile/freenet that referenced this pull request Apr 8, 2020
* Add base template for request money

* Fill tip based on request fund

* Fix update of requests

* avatar text injection opacity

* filter out new github profiles

* allow redemptions of same kudos for diff quests gitcoinco#6300 (comment)

* allow redemptions of same kudos for diff quests gitcoinco#6300 (comment)

* less sleep time between iteratings

* enables visibility filter on /hackathons

* updates stats view

* cache for an hour, make stats GA

* walle and chappie

* active subscriptoins link

* robots.txt for kudos redemptoin links

* fix for wall posts

* raw ids on phantom funds

* better caching architecture for the grants stats page

* fix for extremely strange stats page bug where chrome renders the iframe over top of the rest of the page, by inserting the iframe 100ms after page load

* fixes the caching scheme, and does a quick responsive design fix

* fixes the CLR contribution pks to be passed into a queryst

* troubleshooting docker and mac high cpu usage

Updates with one troubleshooting tip for problems with high CPU usage on mac while installing with docker and links to issues on this topic from docker's for mac repo.

* Add prizes header and hero

* fix bounty details with old cross-chain bounties 0 stdbounties id

* use redirect for 0 std bounties id

* Adds twitter handle support on gitcoin profile handles
Fixes an issue with grants contract owner address
Fixes a grant gas price issue.
fixes an issue with payout of mini clrs where some users were duplciated

* stats for clr

* handles condition in which no txid is broadcast in mini clr payout

* combines activity and description tabs

* fixes gitcoinco#6322 (comment)

* Change layout for hackathon projects

* bug: show categories even when grant has none

* fix/disable tests (ddt)

* - adds a admin comment field on actions for connnor
- updates format of dead grant mail
- adds script to check for grant contribution IP addresses to check for sybil attack

* ability to copy + schedule offer

* schedule offer copy

* hide overlay when you show the tweet modal

* Revert "hide overlay when you show the tweet modal"

This reverts commit 9643fb4.

* Revert "Revert "hide overlay when you show the tweet modal""

This reverts commit 7f1ef93.

* changes the scope of the form_disabled method

* next round start date

* grants round end time now moved to 5pm MST

* escape charset

* Fix serialization of grants for REST API

* Update sidebar_search_hackathon.html

* Favorite a post on town square (gitcoinco#6181)

* Add favorite functionality

* fix eslint

* Update views.py

* fix migrations

Co-authored-by: Dan Lipert <[email protected]>

* Add tribes to townsquare (gitcoinco#6290)

* Add tribes to townsquare

* Fix padding and mergin of buttons

* Change button style to fit CLR style button

Co-authored-by: Dan Lipert <[email protected]>

* fix stylelint

* One Click Fund Issue Link In Townsquare (gitcoinco#6156)

* Allow fund issue from posts with one issue on its content

* Fix lint

Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: Dan Lipert <[email protected]>

* puts searchresults objects in elasticsearch/ makes search GA (gitcoinco#6340)

* POC

* puts documents in elasticsearch

* make fix

* fix typos

Co-authored-by: Dan Lipert <[email protected]>

* fix favorite view props

* new wallee avatar by virtual-face

* better fix for view props

* kudos PKs, removes the lambo one

* respect the mint to address of the token

* fix favorites and sidebar

* fix unfavorite

* Fix serialization of grants for REST API

* adds chappie avatar

* fixes the kudos
1. rendering in frontend
2. allowing URL to be attached to token request
3. now sends an email after that kudos is minted

* fixes the countdown field in all our celery retries

* exponential backoff for kudos redemption

* changes celery multiplier to be smarter

* hotfix that makes kudos celery redemptions actually work reliably

* Typo correction that was breaking instructions.

There was an additional backtick breaking instructions on #### Docker for-mac troubleshooting section, and it has been corrected.

* fix cross chain bounty creation std_bounties_id assignment

* refactor: fixup listen_for_web3_changes

* handle case in which gitcoinbot doesnt exist'

* enable tipping on grants

* Revert "Add hackathon prizes view and projects"

* ads a new avatar

* adds new iamthembot avatar

* Revert "As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder."

* updates avatar

* Add looking for a team option to projects form  (gitcoinco#6348)

* Add option to looking for team members

* Add banner for hackathons

* Restored commented chat functionality on hackathon projects

* Squash migrations on dashboard

* Remove discord from project form

Co-authored-by: Dan Lipert <[email protected]>

* core: base commit for celo + zil + refactor (gitcoinco#6313)

* core: base commit for celo + zil

- update mgmt command to to cater for all cross-chain pending
  fulfillments
- refactor and move all token specific logic to it's own file
  within sync/
- remove un-used url
- update bounty creation to include celo

* set fulfillments > 5 min as expired

* add migration file

* update API wiring for ZIL

* update API wiring for celo

* update bounty creation flow

* bug: rename variable

* celo: update to support cUSD and cGLD

* fixup ZIL backend

* recreate migration

* bug: fix up celo

* Update etc.py

* fix migration

Co-authored-by: Dan Lipert <[email protected]>

* purge: remove private bounties (gitcoinco#6305)

* purge: remove private bounties

- remove BountyDocuments Table
- remove unsigned_nda/signed_nda fields from Bounty + Interest
- remove private repo code in new bounty and bounty detail (vue + jquery)
- updated Bounty serializer to remove BountyDocument and unsigned_nda
- removed images which are not used
- updated email removing private repo code
- remove bounty document upload endpoint used for signd nda upload
- remove private repo specific css
- defaulted repo type to public from frontend

* add migration + UI fixes

* add merge migration

Co-authored-by: Dan Lipert <[email protected]>

* purge: remove pricing + subscibe page (gitcoinco#6397)

Co-authored-by: Dan Lipert <[email protected]>

* bug: https://sentry.io/organizations/gitcoin/issues/1567040592

* chore: add sync_pendinf_fulfillments to cron (gitcoinco#6400)

Co-authored-by: Dan Lipert <[email protected]>

Co-authored-by: Miguel Angel G <[email protected]>
Co-authored-by: owocki <[email protected]>
Co-authored-by: federicosan <[email protected]>
Co-authored-by: Dan Lipert <[email protected]>
Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: octavioamu <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Kevin Owocki <[email protected]>
@owocki
Copy link
Contributor

owocki commented Apr 8, 2020

did this go live? i dont see it on my post https://bits.owocki.com/ApujKEv9

@danlipert
Copy link
Contributor

@owocki its live:
Screen Shot 2020-04-16 at 12 06 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants