puts searchresults objects in elasticsearch/ makes search GA #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6340 +/- ##
==========================================
+ Coverage 27.59% 28.08% +0.49%
==========================================
Files 281 282 +1
Lines 26083 26031 -52
Branches 3843 3833 -10
==========================================
+ Hits 7197 7312 +115
+ Misses 18618 18432 -186
- Partials 268 287 +19
Continue to review full report at Codecov.
|
danlipert
reviewed
Mar 31, 2020
| help = 'uploads search results into elasticsearch' | ||
|
|
||
| def handle(self, *args, **options): | ||
| for sr in SearchResult.objects.all(): |
There was a problem hiding this comment.
One thing thats actually really cool about Django querysets is that it is smart enough to not load all of these objects into memory if you back it with postgres: https://docs.djangoproject.com/en/dev/ref/models/querysets/#iterator
There was a problem hiding this comment.
good call, so sounds like we should use .iterator() here to explicitly do this
danlipert
approved these changes
Mar 31, 2020
octavioamu
approved these changes
Mar 31, 2020
walidmujahid
pushed a commit
to walidmujahid/web
that referenced
this pull request
Apr 1, 2020
…co#6340) * POC * puts documents in elasticsearch * make fix * fix typos Co-authored-by: Dan Lipert <[email protected]>
wizzfile
added a commit
to wizzfile/freenet
that referenced
this pull request
Apr 8, 2020
* Add base template for request money * Fill tip based on request fund * Fix update of requests * avatar text injection opacity * filter out new github profiles * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * allow redemptions of same kudos for diff quests gitcoinco#6300 (comment) * less sleep time between iteratings * enables visibility filter on /hackathons * updates stats view * cache for an hour, make stats GA * walle and chappie * active subscriptoins link * robots.txt for kudos redemptoin links * fix for wall posts * raw ids on phantom funds * better caching architecture for the grants stats page * fix for extremely strange stats page bug where chrome renders the iframe over top of the rest of the page, by inserting the iframe 100ms after page load * fixes the caching scheme, and does a quick responsive design fix * fixes the CLR contribution pks to be passed into a queryst * troubleshooting docker and mac high cpu usage Updates with one troubleshooting tip for problems with high CPU usage on mac while installing with docker and links to issues on this topic from docker's for mac repo. * Add prizes header and hero * fix bounty details with old cross-chain bounties 0 stdbounties id * use redirect for 0 std bounties id * Adds twitter handle support on gitcoin profile handles Fixes an issue with grants contract owner address Fixes a grant gas price issue. fixes an issue with payout of mini clrs where some users were duplciated * stats for clr * handles condition in which no txid is broadcast in mini clr payout * combines activity and description tabs * fixes gitcoinco#6322 (comment) * Change layout for hackathon projects * bug: show categories even when grant has none * fix/disable tests (ddt) * - adds a admin comment field on actions for connnor - updates format of dead grant mail - adds script to check for grant contribution IP addresses to check for sybil attack * ability to copy + schedule offer * schedule offer copy * hide overlay when you show the tweet modal * Revert "hide overlay when you show the tweet modal" This reverts commit 9643fb4. * Revert "Revert "hide overlay when you show the tweet modal"" This reverts commit 7f1ef93. * changes the scope of the form_disabled method * next round start date * grants round end time now moved to 5pm MST * escape charset * Fix serialization of grants for REST API * Update sidebar_search_hackathon.html * Favorite a post on town square (gitcoinco#6181) * Add favorite functionality * fix eslint * Update views.py * fix migrations Co-authored-by: Dan Lipert <[email protected]> * Add tribes to townsquare (gitcoinco#6290) * Add tribes to townsquare * Fix padding and mergin of buttons * Change button style to fit CLR style button Co-authored-by: Dan Lipert <[email protected]> * fix stylelint * One Click Fund Issue Link In Townsquare (gitcoinco#6156) * Allow fund issue from posts with one issue on its content * Fix lint Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: Dan Lipert <[email protected]> * puts searchresults objects in elasticsearch/ makes search GA (gitcoinco#6340) * POC * puts documents in elasticsearch * make fix * fix typos Co-authored-by: Dan Lipert <[email protected]> * fix favorite view props * new wallee avatar by virtual-face * better fix for view props * kudos PKs, removes the lambo one * respect the mint to address of the token * fix favorites and sidebar * fix unfavorite * Fix serialization of grants for REST API * adds chappie avatar * fixes the kudos 1. rendering in frontend 2. allowing URL to be attached to token request 3. now sends an email after that kudos is minted * fixes the countdown field in all our celery retries * exponential backoff for kudos redemption * changes celery multiplier to be smarter * hotfix that makes kudos celery redemptions actually work reliably * Typo correction that was breaking instructions. There was an additional backtick breaking instructions on #### Docker for-mac troubleshooting section, and it has been corrected. * fix cross chain bounty creation std_bounties_id assignment * refactor: fixup listen_for_web3_changes * handle case in which gitcoinbot doesnt exist' * enable tipping on grants * Revert "Add hackathon prizes view and projects" * ads a new avatar * adds new iamthembot avatar * Revert "As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder." * updates avatar * Add looking for a team option to projects form (gitcoinco#6348) * Add option to looking for team members * Add banner for hackathons * Restored commented chat functionality on hackathon projects * Squash migrations on dashboard * Remove discord from project form Co-authored-by: Dan Lipert <[email protected]> * core: base commit for celo + zil + refactor (gitcoinco#6313) * core: base commit for celo + zil - update mgmt command to to cater for all cross-chain pending fulfillments - refactor and move all token specific logic to it's own file within sync/ - remove un-used url - update bounty creation to include celo * set fulfillments > 5 min as expired * add migration file * update API wiring for ZIL * update API wiring for celo * update bounty creation flow * bug: rename variable * celo: update to support cUSD and cGLD * fixup ZIL backend * recreate migration * bug: fix up celo * Update etc.py * fix migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove private bounties (gitcoinco#6305) * purge: remove private bounties - remove BountyDocuments Table - remove unsigned_nda/signed_nda fields from Bounty + Interest - remove private repo code in new bounty and bounty detail (vue + jquery) - updated Bounty serializer to remove BountyDocument and unsigned_nda - removed images which are not used - updated email removing private repo code - remove bounty document upload endpoint used for signd nda upload - remove private repo specific css - defaulted repo type to public from frontend * add migration + UI fixes * add merge migration Co-authored-by: Dan Lipert <[email protected]> * purge: remove pricing + subscibe page (gitcoinco#6397) Co-authored-by: Dan Lipert <[email protected]> * bug: https://sentry.io/organizations/gitcoin/issues/1567040592 * chore: add sync_pendinf_fulfillments to cron (gitcoinco#6400) Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Miguel Angel G <[email protected]> Co-authored-by: owocki <[email protected]> Co-authored-by: federicosan <[email protected]> Co-authored-by: Dan Lipert <[email protected]> Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: octavioamu <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Kevin Owocki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
puts searchresults objects in elasticsearch/ makes search GA
Refers/Fixes
convo with Dan last 1:1
Testing
tested locally. super fast :)