Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVC for RNTester iOS #46439

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

Changelog

[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62501704

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62501704

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Sep 12, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

We still have to fix the `boxShadow` and `filter`. This will happen in a later change.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Sep 12, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62501704

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Sep 12, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

We still have to fix the `boxShadow` and `filter`. This will happen in a later change.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Sep 12, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

We still have to fix the `boxShadow` and `filter`. This will happen in a later change.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Reviewed By: NickGerleman

Differential Revision: D62501704
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Sep 13, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: facebook#46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Differential Revision: D62501704
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62501704

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fad4a07.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in fad4a07

When will my fix make it into a release? | How to file a pick request?

cipolleschi added a commit that referenced this pull request Sep 16, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Summary:
Pull Request resolved: #46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

We still have to fix the `boxShadow` and `filter`. This will happen in a later change.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Reviewed By: NickGerleman

Differential Revision: D62501704

fbshipit-source-id: 3c02f7615c3511a97eba73a2ddaa713d2e4e30f0
@blakef blakef mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants