Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][Codegen] Better support filtering out non linked platforms #48183

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Dec 9, 2024

Summary:

As pointed out by this comment, the property dependency.platforms might not be defined, as the format

{
   "dependencies": {
     "dependency-name": {
       "root": "path/to/dependency",
     }
   }
 }

is also supported.
In this case, we assume that the library is linked to all platforms.
We don't consider the case were dependency-name.root is equal to null, because that means that the library is not linked to the app at all, and in that case the dependency should be removed by the user.

Changelog:

[General][Fixed] - Improve support for filtering out non supported platforms

Test Plan:

Tested on an app with this configuration and it does not crashes.

@cipolleschi cipolleschi changed the base branch from main to 0.76-stable December 9, 2024 14:33
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 9, 2024
@cipolleschi cipolleschi changed the title cipolleschi/fix autolinking forp076 [RN][Codegen] Better support filtering out non linked platforms Dec 9, 2024
@cipolleschi cipolleschi requested a review from blakef December 9, 2024 14:35
@cipolleschi cipolleschi marked this pull request as ready for review December 9, 2024 14:36
@blakef blakef merged commit fcbcf80 into 0.76-stable Dec 9, 2024
8 of 11 checks passed
@blakef blakef deleted the cipolleschi/fix-autolinking-forp076 branch December 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants