[Codegen] Exclude unlinked libs from codegen #47712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
changed the title
cortinico
approved these changes
Dec 3, 2024
satya164
reviewed
Dec 6, 2024
Comment on lines
+314
to
+318
| Object.keys(dependency.platforms).forEach(platform => { | ||
| if (dependency.platforms[platform] == null) { | ||
| notLinkedPlatforms.push(platform); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Previously this was sufficient for module to be linked:
dependencies: {
'name': {
root: '/path/to/your/module',
},
},With this change, projects with this config crash during pod install since the platforms field isn't present.
There was a problem hiding this comment.
Thanks for raising this other case. I believe that if there is just the path, it links for all the platforms, right?
There was a problem hiding this comment.
@cipolleschi currently it crashes when dependency.platforms isn't specified because the above check is accessing keys on dependency.platforms unconditionally
current workaround is to specify:
dependencies: {
'name': {
root: '/path/to/your/module',
platforms: { android: {}, ios: {} },
},
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is a case where a library is added for a specific platform and unlinked for another platform, because perhaps we would like to use a different library.
The way in which this is implemented is through the
react-native.config.jsfile, by setting a specific platform to null.Currently, Codegen ignore this information and generates the code for all the libraries it can find, including the unlinked ones. This can result in build failures because there are some functions prototype defined with no implementation.
This change takes thos libraries into account and it should fix: #47550.
Note
Codegen changed in 0.77, so we don't need to backport this to main
Changelog:
[General][Changed] - Stop generating code for unlinked libraries
Test Plan:
Tested in a new app created with 0.76.2, following the repro steps in #47550