[RN][JS] Fix setUpErrorHandling to show early JS errors #47287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cortinico
approved these changes
Oct 29, 2024
cipolleschi
force-pushed
the
cipolleschi/fix-whitescreen
branch
2 times, most recently
from
2838eff to
8e8d273
Compare
cipolleschi
force-pushed
the
cipolleschi/fix-whitescreen
branch
from
8e8d273 to
00d5f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This should fix 47215. The problem is that we are reworking the error pipeline and this commit made into the stable branch, while the TODO didn't.
This change restore this file to the 0.75 version.
Changelog:
[General][Fixed] - Show early JS errors properly when they happens
Test Plan:
Tested in the repro from 47215.