fix(baseapp): avoid header height overwrite block height

[mmsqe]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features
  • Enhanced the application to allow overriding the default block height in headers for more flexible data handling.
• Tests
  • Updated test cases to support the new height override functionality, ensuring robustness and reliability.

[coderabbitai]

Walkthrough

The recent update in the Cosmos SDK's baseapp module involves modifying the handling of block height during the creation of query contexts. This change impacts how heights are managed, potentially affecting historical data retrieval and the handling of block height in various operations.

Changes

File Path	Change Summary
baseapp/abci.go	Modified the position of WithBlockHeight method call in CreateQueryContext.
baseapp/baseapp_test.go	Updated test cases to accommodate new headerHeight field and adjusted logic for initial height setting.

Possibly related issues

• [Bug]: Certain calls with x-cosmos-block-height are broken #19822: The changes in handling block height could address the version mismatch and block height issues reported in historical queries.
• Add heights to every gRPC request ibc-go#149: By altering how heights are handled in requests, this change aligns with objectives to improve height management in gRPC requests.
• Validator.UnbondingHeight meaning is inconsistent, misused and not useful. #12486: Although indirectly related, better clarity and handling of block heights might influence related fields and operations like Validator.UnbondingHeight.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cool-develope]

@mmsqe could you please provide some more context?

[mmsqe]

@mmsqe could you please provide some more context?

ctx.BlockHeight() should be used in keeper when block height header is absent, which is the case of cli call like before

ethermintd q evm params --node tcp://127.0.0.1:26657 --height 2

[facundomedica]

LGTM, is this an issue in main only? Or should we backport it?

[mmsqe]

LGTM, is this an issue in main only? Or should we backport it?

would be nice if can backport v0.50.x, no issue in v0.47.x

[julienrbrt]

utACK