feat(crypto/keyring): add Linux's keyctl support

[alessio]

Description

Supersedes #17607

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced a bulk-add-genesis-account command in the CLI for easier management of multiple genesis accounts.
  • Added a Linux-specific keyring backend for enhanced key management capabilities.

• Improvements

  • Enhanced documentation for the keyring package, detailing the new Linux keyctl backend.
  • Updated the CHANGELOG to reflect the latest features and improvements.

[coderabbitai]

Walkthrough

Walkthrough

The changes introduce enhancements to the Cosmos SDK's keyring functionality. A new CLI command, bulk-add-genesis-account, enables the addition of multiple genesis accounts simultaneously. Additionally, a Linux-specific backend using the keyctl for key management has been implemented, alongside a separate implementation for non-Linux environments. Documentation has been updated to reflect these changes, and relevant entries have been added to the CHANGELOG.md.

Changes

Files	Change Summary
CHANGELOG.md	Added an entry for the bulk-add-genesis-account command and the implementation of a Linux-only backend that adds Linux kernel's keyctl support in the crypto/keyring module.
crypto/keyring/keyring.go	Removed Options struct and renamed New function to newKeyringGeneric.
crypto/keyring/keyring_linux.go	Added Linux-specific keyring support with a new New function and newKeyctlBackendConfig for keyring configuration using the keyctl backend.
crypto/keyring/keyring_other.go	Added a New function for non-Linux environments that delegates to newKeyringGeneric for keyring instance creation and introduced an Options struct for configuration.
crypto/keyring/keyring_linux_test.go	Introduced a test suite for the NewKeyctlKeyring function to verify the creation of a keyring using the keyctl backend on Linux.
crypto/keyring/doc.go	Updated documentation for the keyctl backend to clarify its functionality and exclusivity to Linux environments.

Possibly related PRs

• chore: sync changelog with latest releases #21658: The changes in this PR involve updates to the CHANGELOG.md, including the entry for the bulk-add-genesis-account command, which is directly related to the main PR's introduction of this command.

---

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fedc20a and e3e7c26.

Files selected for processing (1)

• CHANGELOG.md (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• CHANGELOG.md

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alessio]

@tac0turtle 😃

[raynaudoe]

LGTM. Please take a look at the failing tests. Thanks

[raynaudoe]

Can you add a clarification on which are the granted permissions here?

[alessio]

I am doing more work to provide users with sensible perms/scope options

[alessio]

By default, user and session keyring give access to the owner (i.e. the creator) only

[alessio]

Hello again, gals and lads! Can we have this backported to v0.52.x and v0.50.0x, please?

Thanks for considering.

[julienrbrt]

Hello again, gals and lads! Can we have this backported to v0.52.x and v0.50.0x, please?

Thanks for considering.

As it is not API breaking let's do it 👌🏾

[alessio]

Should I reopen this PR?

[julienrbrt]

@Mergifyio backport release/v0.52.x

[julienrbrt]

@Mergifyio backport release/v0.50.x

[mergify]

backport release/v0.52.x

✅ Backports have been created

• #21839 feat(crypto/keyring): add Linux's keyctl support (backport #21653) has been created for branch release/v0.52.x but encountered conflicts

[mergify]

backport release/v0.50.x

✅ Backports have been created

• #21840 feat(crypto/keyring): add Linux's keyctl support (backport #21653) has been created for branch release/v0.50.x but encountered conflicts