chore(x/group): update supported flags

[julienrbrt]

Description

Closes: #22220

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced new CLI commands for creating and updating groups and group policies.
  • Enhanced proposal submission command with improved execution options.

• Bug Fixes

  • Improved error handling for various command scenarios.

• Documentation

  • Updated command descriptions for clarity and usability.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on enhancing the command-line interface (CLI) for group transactions within the x/group module. Key updates include modifications to existing commands and the introduction of new commands for group and policy management. Additionally, error handling has been improved, and the help string for the FlagExec flag has been corrected to clarify its usage.

Changes

File Path	Change Summary
x/group/client/cli/tx.go	Updated MsgSubmitProposalCmd help string for FlagExec to allow "1" or "try". Added new commands: MsgCreateGroupCmd, MsgUpdateGroupMembersCmd, MsgCreateGroupWithPolicyCmd, MsgCreateGroupPolicyCmd, MsgUpdateGroupPolicyDecisionPolicyCmd, and modified existing command error handling.
x/group/client/cli/util.go	Modified execFromString function to check for "1" in addition to ExecTry.

Assessment against linked issues

Objective	Addressed	Explanation
Update help string for --exec flag (Issue #22220)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 60cbe2d and 70557ba.

📒 Files selected for processing (2)

• x/group/client/cli/tx.go (1 hunks)
• x/group/client/cli/util.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

x/group/client/cli/tx.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/group/client/cli/util.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

[coderabbitai]

⚠️ Potential issue

Remove the condition for "1" to align with PR objectives

The current change contradicts the PR objectives and the linked issue #22220. Adding the condition execStr == "1" allows "1" as a valid input for immediate execution, which is precisely what we're trying to correct.

Please modify the function to only accept "try" (case-insensitive) for immediate execution. Here's the suggested change:

-if execStr == ExecTry || execStr == "1" {
+if strings.EqualFold(execStr, ExecTry) {
 	exec = group.Exec_EXEC_TRY
}

Also, consider adding a comment explaining the accepted values:

// execFromString converts a string to group.Exec
// Only "try" (case-insensitive) is accepted for immediate execution
// All other values result in group.Exec_EXEC_UNSPECIFIED
func execFromString(execStr string) group.Exec {
	// ... (rest of the function)
}

This change ensures that only "try" (case-insensitive) is accepted for immediate execution, aligning with the PR objectives and preventing potential confusion or bugs.

[coderabbitai]

⚠️ Potential issue

Correct the help string to accurately reflect the allowed value for FlagExec.

The help string suggests that both 1 and 'try' can be used to execute the proposal immediately after creation. However, according to the PR objectives and linked issue #22220, only 'try' is the valid value. Using 1 does not trigger immediate execution and can lead to confusion for users. Please update the help string to reflect this accurately.

Apply this diff to correct the help string:

-cmd.Flags().String(FlagExec, "", "Set to 1 or 'try' to try to execute proposal immediately after creation (proposers signatures are considered as Yes votes)")
+cmd.Flags().String(FlagExec, "", "Set to 'try' to execute proposal immediately after creation (proposers signatures are considered as Yes votes)")

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	cmd.Flags().String(FlagExec, "", "Set to 1 or 'try' to try to execute proposal immediately after creation (proposers signatures are considered as Yes votes)")
	cmd.Flags().String(FlagExec, "", "Set to 'try' to execute proposal immediately after creation (proposers signatures are considered as Yes votes)")