-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bring patch changelogs to main #20599
Conversation
WalkthroughWalkthroughThe Changes
Sequence Diagram(s) (Beta)N/A Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range and nitpick comments (3)
x/upgrade/CHANGELOG.md (2)
Line range hint
67-67
: Add a missing comma and the preposition "to" for grammatical correctness.- ... a separate go.mod file which allows it be a standalone module. + ... a separate go.mod file which allows it to be a standalone module.Tools
Markdownlint
43-43: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
Line range hint
81-81
: Remove the extra blank line to adhere to Markdown best practices.-
Tools
Markdownlint
43-43: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentationCHANGELOG.md (1)
66-66
: Ensure consistency in changelog formatting.Consider adding a header or some form of separation before the "Improvements" section to maintain consistency with other sections in the changelog.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (4 hunks)
- x/upgrade/CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (2)
x/upgrade/CHANGELOG.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"CHANGELOG.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
x/upgrade/CHANGELOG.md
[uncategorized] ~67-~67: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... is extracted to have a separate go.mod file which allows it be a standalone module....
[grammar] ~67-~67: The preposition ‘to’ may be missing (allow someone to do something). (ALLOW_TO_DO)
Context: ... a separate go.mod file which allows it be a standalone module. ### Improvements ...
Markdownlint
x/upgrade/CHANGELOG.md
43-43: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
81-81: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank linesCHANGELOG.md
70-70: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
71-71: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
75-75: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
76-76: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
77-77: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
83-83: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
125-125: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
126-126: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
127-127: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
131-131: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
134-134: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
135-135: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
136-136: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
143-143: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
153-153: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
155-155: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
158-158: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
177-177: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
178-178: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
180-180: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
181-181: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
230-230: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
231-231: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
232-232: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
396-396: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
399-399: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
421-421: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
422-422: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
435-435: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
467-467: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
468-468: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
469-469: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
470-470: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
472-472: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
473-473: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
474-474: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
475-475: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
489-489: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
491-491: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
493-493: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
495-495: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
498-498: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
499-499: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
500-500: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
508-508: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
509-509: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
511-511: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
512-512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
514-514: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
515-515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
516-516: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
518-518: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
519-519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
527-527: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
538-538: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
539-539: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
540-540: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
546-546: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
547-547: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
548-548: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
554-554: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
570-570: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
571-571: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
572-572: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
573-573: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
574-574: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
575-575: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
580-580: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
581-581: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
582-582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
590-590: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
591-591: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
592-592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
626-626: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
627-627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
628-628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
629-629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
634-634: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
635-635: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
783-783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
926-926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
947-947: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
950-950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1032-1032: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1033-1033: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1034-1034: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1035-1035: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1036-1036: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1037-1037: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1134-1134: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1220-1220: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1266-1266: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1272-1272: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1273-1273: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1274-1274: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1275-1275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1277-1277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1377-1377: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1502-1502: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1503-1503: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1504-1504: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1505-1505: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1506-1506: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1507-1507: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1508-1508: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1509-1509: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1512-1512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1513-1513: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1514-1514: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1515-1515: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1516-1516: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1517-1517: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
1766-1766: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1767-1767: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1768-1768: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1769-1769: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1770-1770: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1771-1771: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
1881-1881: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2218-2218: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2219-2219: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2220-2220: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2223-2223: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2224-2224: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2225-2225: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2247-2247: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2248-2248: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2249-2249: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2250-2250: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2251-2251: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2259-2259: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2260-2260: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2261-2261: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2262-2262: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2263-2263: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2265-2265: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2266-2266: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2267-2267: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2594-2594: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2595-2595: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2596-2596: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2597-2597: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2598-2598: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2600-2600: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2602-2602: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2603-2603: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2604-2604: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2609-2609: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2610-2610: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2611-2611: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2614-2614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2615-2615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2618-2618: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2621-2621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2624-2624: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2627-2627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2628-2628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2631-2631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2638-2638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2639-2639: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2640-2640: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2642-2642: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2644-2644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2645-2645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2646-2646: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2647-2647: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2652-2652: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2655-2655: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2656-2656: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2667-2667: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2668-2668: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2669-2669: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2677-2677: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2679-2679: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2681-2681: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2682-2682: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2683-2683: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2684-2684: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2685-2685: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2686-2686: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2688-2688: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2690-2690: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2694-2694: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2695-2695: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2696-2696: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2697-2697: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2698-2698: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2704-2704: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2705-2705: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2707-2707: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2709-2709: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2710-2710: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2712-2712: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2713-2713: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2714-2714: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2715-2715: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2716-2716: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2717-2717: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2718-2718: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2721-2721: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2722-2722: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2724-2724: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2725-2725: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2728-2728: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2729-2729: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2730-2730: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2731-2731: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2732-2732: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2733-2733: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2734-2734: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2735-2735: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2737-2737: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2738-2738: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2739-2739: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2745-2745: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2748-2748: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2754-2754: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2762-2762: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2763-2763: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2764-2764: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2765-2765: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2773-2773: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2780-2780: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2781-2781: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2788-2788: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2790-2790: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2794-2794: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2795-2795: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2797-2797: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2805-2805: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2807-2807: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2808-2808: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2814-2814: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2822-2822: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2823-2823: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2824-2824: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2825-2825: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2826-2826: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2827-2827: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2828-2828: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2829-2829: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2830-2830: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2831-2831: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2837-2837: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2838-2838: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2840-2840: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2841-2841: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2842-2842: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2843-2843: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2844-2844: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2845-2845: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2846-2846: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2848-2848: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2849-2849: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2851-2851: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2852-2852: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2855-2855: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2856-2856: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2858-2858: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2859-2859: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2860-2860: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2861-2861: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2862-2862: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2863-2863: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2864-2864: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2865-2865: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2866-2866: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2867-2867: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2868-2868: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2869-2869: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2870-2870: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2875-2875: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2876-2876: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2877-2877: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2878-2878: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2882-2882: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2884-2884: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2898-2898: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2899-2899: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2900-2900: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2905-2905: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2906-2906: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2907-2907: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2911-2911: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2912-2912: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2913-2913: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2914-2914: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2919-2919: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2920-2920: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2921-2921: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2927-2927: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2931-2931: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2933-2933: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2938-2938: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2939-2939: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2940-2940: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2942-2942: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2943-2943: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2944-2944: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2945-2945: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2946-2946: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2947-2947: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2948-2948: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2949-2949: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2950-2950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2951-2951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2952-2952: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2953-2953: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation
2954-2954: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2955-2955: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2956-2956: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2957-2957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
2958-2958: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
187-187: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
227-227: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
1684-1684: null (MD034, no-bare-urls)
Bare URL used
1714-1714: null (MD034, no-bare-urls)
Bare URL used
2661-2661: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2749-2749: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2751-2751: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2756-2756: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2758-2758: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2768-2768: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2770-2770: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2775-2775: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2783-2783: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2800-2800: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2802-2802: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2810-2810: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2816-2816: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2886-2886: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2889-2889: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2892-2892: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2894-2894: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
2934-2934: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1055-1055: null (MD038, no-space-in-code)
Spaces inside code span elements
2702-2702: null (MD038, no-space-in-code)
Spaces inside code span elements
2702-2702: null (MD038, no-space-in-code)
Spaces inside code span elements
Additional comments not posted (2)
CHANGELOG.md (2)
203-219
: Review for completeness and accuracy of changelog entries.Verification successful
The verification process confirms that the changes mentioned in the PRs are reflected in the codebase. Each PR's implementation details were found in the relevant files, matching the descriptions provided in the changelog.
- PR feat(client): add consensus address for debug cmd #20328: Consensus address references found in multiple files.
- PR feat(baseapp): expose grpc query router via depinject. #20264: No direct matches for "grpc query router," but this might be due to different terminology or implementation details.
- PR fix(x/consensus): harden consensus params proposal #20381: No direct matches for "Comet utility," similar reasoning as above.
- PR feat(client): overwrite client context instead of setting new one #20356:
SetCmdClientContext
references found in multiple files.- PR fix: correctly assign
execModeSimulate
to context forsimulateTx
(backport #20342) #20346:execModeSimulate
references found in multiple files.- PR fix: remove txs from mempool when antehandler fails in recheck #20144: No direct matches for "AnteHandler fails," but this might be due to different terminology or implementation details.
- PR fix(baseapp): avoid header height overwrite block height #20107: Reference to "header height" found.
- PR fix(server): bootstrap-state command can't parse latest genesis format #20020:
bootstrap-state
command references found.- PR fix(testsuite/sims): set all signatures #20151:
GenSignedMockTx
references found in multiple files.Given the evidence from the codebase, the changelog entries appear to be accurate and complete.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all listed changes are reflected in the codebase and documentation. # Test: Search for the PRs and ensure all changes are documented. rg --type md -g '*CHANGELOG.md' '20328|20264|20381|20356|20346|20144|20107|20020|20151'Length of output: 1674
Script:
#!/bin/bash # Verify the implementation of each PR in the codebase. # PR #20328: Add consensus address for debug cmd. rg 'consensus address' --type go # PR #20264: Expose grpc query router via depinject. rg 'grpc query router' --type go # PR #20381: Use Comet utility for consensus module consensus param updates. rg 'Comet utility' --type go # PR #20356: Overwrite client context when available in `SetCmdClientContext`. rg 'SetCmdClientContext' --type go # PR #20346: Correctly assign `execModeSimulate` to context for `simulateTx`. rg 'execModeSimulate' --type go # PR #20144: Remove txs from mempool when AnteHandler fails in recheck. rg 'AnteHandler fails' --type go # PR #20107: Avoid header height overwrite block height. rg 'header height' --type go # PR #20020: Make bootstrap-state command support both new and legacy genesis format. rg 'bootstrap-state' --type go # PR #20151: Set all signatures and don't overwrite the previous one in `GenSignedMockTx`. rg 'GenSignedMockTx' --type goLength of output: 9756
66-66
: Ensure all entries are correctly categorized.
* (deps) [#20530](https://github.com/cosmos/cosmos-sdk/pull/20530) Bump vulnerable `github.com/hashicorp/go-getter` to v1.7.4. | ||
* In theory, we do not need a new release for this, but we are doing it as `x/upgrade` is used in Cosmovisor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the indentation level for the unordered list.
- * In theory, we do not need a new release for this, but we are doing it as `x/upgrade` is used in Cosmovisor.
+ * In theory, we do not need a new release for this, but we are doing it as `x/upgrade` is used in Cosmovisor.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
* (deps) [#20530](https://github.com/cosmos/cosmos-sdk/pull/20530) Bump vulnerable `github.com/hashicorp/go-getter` to v1.7.4. | |
* In theory, we do not need a new release for this, but we are doing it as `x/upgrade` is used in Cosmovisor. | |
* (deps) [#20530](https://github.com/cosmos/cosmos-sdk/pull/20530) Bump vulnerable `github.com/hashicorp/go-getter` to v1.7.4. | |
* In theory, we do not need a new release for this, but we are doing it as `x/upgrade` is used in Cosmovisor. |
Tools
Markdownlint
43-43: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
## [v0.47.12](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.12) - 2024-06-10 | ||
|
||
## Improvements | ||
|
||
* (x/authz,x/feegrant) [#20590](https://github.com/cosmos/cosmos-sdk/pull/20590) Provide updated keeper in depinject for authz and feegrant modules. | ||
|
||
### Bug Fixes | ||
|
||
* (baseapp) [#20144](https://github.com/cosmos/cosmos-sdk/pull/20144) Remove txs from mempool when AnteHandler fails in recheck. | ||
* (testutil/sims) [#20151](https://github.com/cosmos/cosmos-sdk/pull/20151) Set all signatures and don't overwrite the previous one in `GenSignedMockTx`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for duplication in changelog entries.
It appears that some bug fixes are listed multiple times in different versions. Please ensure that each entry is unique to avoid confusion.
- * (baseapp) [#20144](https://github.com/cosmos/cosmos-sdk/pull/20144) Remove txs from mempool when AnteHandler fails in recheck.
- * (testutil/sims) [#20151](https://github.com/cosmos/cosmos-sdk/pull/20151) Set all signatures and don't overwrite the previous one in `GenSignedMockTx`.
Committable suggestion was skipped due to low confidence.
* main: refactor(x/auth): Fix system test (#20531) feat(crypto): add blst (#20296) docs: Update high level overview and introduction (#20535) refactor(x/core): remove test (#20624) feat(x/mint)!: Replace InflationCalculationFn with MintFn + simple epoch minting (#20363) docs: remove duplicate words (#20622) feat: prep for errors v2 (#20539) chore: reduce default inflation (#20606) refactor(store): add miss defer (#20602) chore: use comet api pkg instead of comet alias (#20614) chore: write gentx info to cmd.ErrOrStderr (#20616) docs: ADR 073: update to accepted and add to README.md (#20619) chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 (#20600) fix: remove some duplicate words (#20605) feat(stf): port simappv2 changes (#20587) chore: bring patch changelogs to main (#20599)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Chores
github.com/hashicorp/go-getter
to v1.7.4 in the upgrade module.