-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 #20600
Conversation
WalkthroughWalkthroughThe changes primarily involve downgrading version numbers from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (4)
x/authz/tx.pb.go
is excluded by!**/*.pb.go
x/gov/types/v1/gov.pb.go
is excluded by!**/*.pb.go
x/gov/types/v1/query.pb.go
is excluded by!**/*.pb.go
x/gov/types/v1/tx.pb.go
is excluded by!**/*.pb.go
Files selected for processing (8)
- api/cosmos/authz/v1beta1/tx.pulsar.go (1 hunks)
- api/cosmos/gov/v1/gov.pulsar.go (4 hunks)
- api/cosmos/gov/v1/query.pulsar.go (2 hunks)
- api/cosmos/gov/v1/tx.pulsar.go (1 hunks)
- x/authz/proto/cosmos/authz/v1beta1/tx.proto (1 hunks)
- x/gov/proto/cosmos/gov/v1/gov.proto (3 hunks)
- x/gov/proto/cosmos/gov/v1/query.proto (1 hunks)
- x/gov/proto/cosmos/gov/v1/tx.proto (1 hunks)
Files skipped from review due to trivial changes (2)
- api/cosmos/gov/v1/query.pulsar.go
- x/gov/proto/cosmos/gov/v1/query.proto
Additional context used
Path-based instructions (3)
api/cosmos/authz/v1beta1/tx.pulsar.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/gov/v1/gov.pulsar.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/gov/v1/tx.pulsar.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (13)
x/authz/proto/cosmos/authz/v1beta1/tx.proto (2)
109-109
: Version annotation downgrade fromv1.0.0
tov0.2.0
inMsgPruneExpiredGrants
.This change aligns with the PR's objective to adjust the versioning in anticipation of future module extractions.
117-117
: Version annotation downgrade fromv1.0.0
tov0.2.0
inMsgPruneExpiredGrantsResponse
.This version change is consistent with the downgrade in
MsgPruneExpiredGrants
, ensuring consistency across related message types.x/gov/proto/cosmos/gov/v1/tx.proto (1)
101-101
: Version annotation downgrade fromv1.0.0
tov0.2.0
inMsgSubmitProposal
.The version downgrade reflects the PR's goal to adjust versioning in the governance module, aligning with the broader strategy of version management before SDK dependencies are removed.
x/gov/proto/cosmos/gov/v1/gov.proto (4)
133-133
: Version annotation downgrade fromv1.0.0
tov0.2.0
inProposalType
withinProposal
.This change is part of the systematic version downgrades across the governance module, ensuring that all components reflect the new version strategy.
160-160
: Version annotation downgrade fromv1.0.0
tov0.2.0
inProposalVoteOptions
.This update ensures that the version annotations are consistent across the governance module, aligning with the changes made in other parts of the module.
327-327
: Multiple version annotation downgrades inParams
.These changes are consistent with the PR's objectives and reflect a broader strategy to manage versions more conservatively until SDK dependencies are fully resolved.
Also applies to: 332-332, 337-337, 341-341, 345-345
352-352
: Version annotation downgrade inMessageBasedParams
.This change aligns with the consistent version management strategy across the governance module, ensuring that all new features and updates reflect the revised versioning approach.
api/cosmos/authz/v1beta1/tx.pulsar.go (1)
4893-4897
: Version downgrade fromv1.0.0
tov0.2.0
correctly implemented in the byte array.api/cosmos/gov/v1/gov.pulsar.go (4)
10426-10426
: Version downgrade fromv1.0.0
tov0.2.0
aligns with PR objectives.
10440-10440
: Version downgrade fromv1.0.0
tov0.2.0
aligns with PR objectives.
10592-10599
: Version downgrade fromv1.0.0
tov0.2.0
aligns with PR objectives.
10636-10636
: Version downgrade fromv1.0.0
tov0.2.0
aligns with PR objectives.api/cosmos/gov/v1/tx.pulsar.go (1)
11132-11132
: Version annotation updated correctly fromv1.0.0
tov0.2.0
forProposalType
.
* main: refactor(x/auth): Fix system test (#20531) feat(crypto): add blst (#20296) docs: Update high level overview and introduction (#20535) refactor(x/core): remove test (#20624) feat(x/mint)!: Replace InflationCalculationFn with MintFn + simple epoch minting (#20363) docs: remove duplicate words (#20622) feat: prep for errors v2 (#20539) chore: reduce default inflation (#20606) refactor(store): add miss defer (#20602) chore: use comet api pkg instead of comet alias (#20614) chore: write gentx info to cmd.ErrOrStderr (#20616) docs: ADR 073: update to accepted and add to README.md (#20619) chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 (#20600) fix: remove some duplicate words (#20605) feat(stf): port simappv2 changes (#20587) chore: bring patch changelogs to main (#20599)
Description
We won't manage to totally remove the SDK imports for this release, so we'll stick with 0ver until the SDK dep is gone.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
v1.0.0
tov0.2.0
in various protocol buffer definitions across multiple modules.These changes ensure compatibility with earlier versions, improving integration flexibility with other systems.