Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): don't hardcode grpc address to localhost #18254

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(server): don't hardcode grpc address to localhost #18254

merged 2 commits into from
Oct 25, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 25, 2023 •
edited by coderabbitai bot
Loading

Description

Closes: #18172

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

Release Notes:

  • Bug Fix: Resolved an issue in the server configuration that previously hardcoded the gRPC address to localhost. This change enhances the flexibility of server setup and improves the reliability of the gRPC client connection.
  • Bug Fix: Corrected a function in the slashing/migration module that was causing issues with missed blocks key. This fix ensures accurate tracking of missed blocks, enhancing the system's stability.
  • Bug Fix: Improved the governance module to fail any inactive and active proposals with undecodable messages. This change increases the robustness of the proposal system.
  • Bug Fix: Fixed an issue with a simulation test command that was not executing properly. This fix improves the reliability of our simulation tests, ensuring more accurate results.

@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Oct 25, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner October 25, 2023 12:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 25, 2023 •
edited
Loading

Walkthrough

This pull request addresses several bugs across different modules, including the server, slashing, gov, and simulation packages. The changes primarily focus on fixing hardcoded values, improving error handling, and enhancing the execution of simulation tests.

Changes

File(s) Summary
server/start.go Removed the hardcoded gRPC address and replaced it with a configurable address.
.../slashing/migration/v4 Fixed the builder function for missed blocks key.
.../x/gov Improved error handling for undecodable messages in inactive and active proposals.
.../simulation Resolved issues with executing a specific command for simulation tests.

🐇 "In the land of code, where the shadows lie,

Bugs were squashed, no longer they fly.

Hardcoded values, now they flee,

In the realm of logic, we are free. 🎉"

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team October 25, 2023 12:25
coderabbitai[bot]
coderabbitai bot reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 139a29e and 717529c.
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • server/start.go (3 hunks)
Files skipped from review due to trivial changes (1)
  • server/start.go
Additional comments: 1
CHANGELOG.md (1)
  • 73-73: The changes in the CHANGELOG.md file accurately reflect the bug fixes and improvements made in this PR. The added entry about not hardcoding the gRPC address to localhost provides a clear description of the change and links to the relevant PR for more context.

alexanderbez
alexanderbez approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt @alexanderbez
feedback
e97d588 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
coderabbitai[bot]
coderabbitai bot reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 717529c and e97d588.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 1
CHANGELOG.md (1)
  • 73-73: The new hunk adds a bug fix for the server module where the gRPC address was hardcoded to localhost. This change is important for the flexibility and adaptability of the server setup.

@julienrbrt julienrbrt added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 894bebc Oct 25, 2023
57 checks passed
@julienrbrt julienrbrt deleted the julien/dont-overwrite-grpc-server-url branch October 25, 2023 18:06
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@julienrbrt @mergify
fix(server): don't hardcode grpc address to localhost (#18254)
9c8a924 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
(cherry picked from commit 894bebc)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
julienrbrt added a commit that referenced this pull request Oct 25, 2023
@mergify @julienrbrt
fix(server): don't hardcode grpc address to localhost (backport #18254)…
9c6c648 
… (#18258)

Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request Oct 25, 2023
@mergify @julienrbrt
fix(server): don't hardcode grpc address to localhost (backport #18254)…
8c9ab2c 
… (#18259)

Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request Oct 25, 2023
@mergify @julienrbrt
fix(server): don't hardcode grpc address to localhost (backport #18254)…
41d2a21 
… (#18260)

Co-authored-by: Julien Robert <[email protected]>
rootulp pushed a commit to rootulp/cosmos-sdk that referenced this pull request Nov 7, 2023
@mergify @julienrbrt @rootulp
fix(server): don't hardcode grpc address to localhost (backport cosmo…
525c581 
…s#18254) (cosmos#18260)

Co-authored-by: Julien Robert <[email protected]>
rootulp added a commit to celestiaorg/cosmos-sdk that referenced this pull request Nov 14, 2023
@rootulp @mergify
@mmsqe @julienrbrt @itsdevbear @devon-chain @fmorency @bryanchriswhite @tac0turtle
chore: upgrade to cosmos-sdk v0.46.16 (#357)
e04d485 
* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <[email protected]>

* fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.46.15 (cosmos#17408)

* fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527)

Co-authored-by: devon <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549)

Co-authored-by: Félix C. Morency <[email protected]>

* fix: typo in comment (backport cosmos#17635) (cosmos#17638)

Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Marko <[email protected]>

* build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare release notes v0.46.16 (cosmos#18118)

* fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260)

Co-authored-by: Julien Robert <[email protected]>

* chore: update tag date v0.46.16 (cosmos#18385)

* revert: Go 1.19

* revert: c226e8b

* chore(deps): upgrade to v1.29.0-tm-v0.34.29

* chore: downgrade to grpc 1.54.0

to match the versions used in upstream

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Devon Bear <[email protected]>
Co-authored-by: devon <[email protected]>
Co-authored-by: Félix C. Morency <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Marko <[email protected]>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @julienrbrt @JeancarloBarrios
fix(server): don't hardcode grpc address to localhost (backport cosmo…
ba775cd 
…s#18254) (cosmos#18260)

Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@alexanderbez alexanderbez

@tac0turtle tac0turtle

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: grpc server address does not follow app.toml
3 participants
@julienrbrt @alexanderbez @tac0turtle