Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to cosmos-sdk v0.46.16 #357

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 7, 2023

Closes #353

I cherry-picked the commits from v0.46.14 up to v0.46.16: cosmos/cosmos-sdk@v0.46.14...v0.46.16

git cherry-pick 16d52690792e6e9446097ca5b48179a01a0c24e9^..7799bba7bc889288607576aa11655b5fc31a2da9

Testing

Verified that I can still sign txs with from celestia-app using this cosmos-sdk

mergify bot and others added 13 commits November 7, 2023 17:21
@rootulp rootulp requested a review from cmwaters November 7, 2023 16:25
@rootulp rootulp self-assigned this Nov 7, 2023
go.mod Outdated Show resolved Hide resolved
@rootulp rootulp mentioned this pull request Nov 7, 2023
19 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #357 (5f4f57f) into release/v0.46.x-celestia (76bcf5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           release/v0.46.x-celestia     #357   +/-   ##
=========================================================
  Coverage                     65.54%   65.55%           
=========================================================
  Files                           666      666           
  Lines                         71188    71180    -8     
=========================================================
+ Hits                          46661    46662    +1     
+ Misses                        21944    21935    -9     
  Partials                       2583     2583           
Files Coverage Δ
client/config/config.go 55.76% <100.00%> (ø)
crypto/keyring/keyring.go 63.04% <100.00%> (ø)
crypto/ledger/ledger_mock.go 60.00% <100.00%> (ø)
crypto/ledger/ledger_secp256k1.go 56.12% <100.00%> (+2.75%) ⬆️

... and 1 file with indirect coverage changes

@@ -18,7 +18,7 @@ require (
github.com/cosmos/cosmos-sdk/db v1.0.0-beta.1
github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/iavl v0.19.6
github.com/cosmos/ledger-cosmos-go v0.13.2
github.com/cosmos/ledger-cosmos-go v0.12.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ledger-cosmos-go release notes are sparse but 0.12.4 and 0.13.2 should contain the hotfix needed for Ledger to work on MacOS.

Ref: https://github.com/cosmos/ledger-cosmos-go/releases

go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
to match the versions used in upstream
@rootulp rootulp marked this pull request as ready for review November 8, 2023 10:30
@rootulp rootulp mentioned this pull request Nov 8, 2023
@rootulp rootulp merged commit e04d485 into celestiaorg:release/v0.46.x-celestia Nov 14, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants