Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct config key for db_backend #17406

Merged
merged 7 commits into from
Aug 16, 2023
Merged

fix: use correct config key for db_backend #17406

merged 7 commits into from
Aug 16, 2023

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #17181
ref: #17181 (comment)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 16, 2023
@github-actions github-actions bot added C:Confix Issues and PR related to Confix and removed backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 16, 2023
@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 16, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 16, 2023 12:14
@julienrbrt julienrbrt requested a review from a team as a code owner August 16, 2023 12:14
@github-prbot github-prbot requested review from a team, alexanderbez and atheeshp and removed request for a team August 16, 2023 12:19
@julienrbrt julienrbrt added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 6b0f8ad Aug 16, 2023
@julienrbrt julienrbrt deleted the julien/db-backend branch August 16, 2023 18:32
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@julienrbrt @mergify
fix: use correct config key for db_backend (#17406)
cd3ae48 
Co-authored-by: Kevin Yang <[email protected]>
(cherry picked from commit 6b0f8ad)
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@julienrbrt @mergify
fix: use correct config key for db_backend (#17406)
3d540b7 
Co-authored-by: Kevin Yang <[email protected]>
(cherry picked from commit 6b0f8ad)

# Conflicts:
#	server/config/toml.go
#	server/util_test.go
#	tools/confix/data/v0.47-app.toml
#	tools/confix/data/v0.50-app.toml
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@julienrbrt @mergify
fix: use correct config key for db_backend (#17406)
3bc8ab4 
Co-authored-by: Kevin Yang <[email protected]>
(cherry picked from commit 6b0f8ad)

# Conflicts:
#	CHANGELOG.md
#	server/config/toml.go
#	server/util.go
#	server/util_test.go
#	tools/confix/data/v0.47-app.toml
#	tools/confix/data/v0.50-app.toml
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Aug 16, 2023
@mergify
fix: use correct config key for db_backend (backport #17406) (#17410)
57a22c1
julienrbrt added a commit that referenced this pull request Aug 16, 2023
@mergify @julienrbrt
fix: use correct config key for db_backend (backport #17406) (#17411)
72a6397 
Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request Aug 16, 2023
@mergify @julienrbrt
fix: use correct config key for db_backend (backport #17406) (#17412)
f83dca0 
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Sep 5, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Oct 15, 2023
Closed
19 tasks
rootulp pushed a commit to rootulp/cosmos-sdk that referenced this pull request Nov 7, 2023
@mergify @julienrbrt @rootulp
fix: use correct config key for db_backend (backport cosmos#17406) (c…
5f62bd6 
…osmos#17412)

Co-authored-by: Julien Robert <[email protected]>
rootulp added a commit to celestiaorg/cosmos-sdk that referenced this pull request Nov 14, 2023
@rootulp @mergify
@mmsqe @julienrbrt @itsdevbear @devon-chain @fmorency @bryanchriswhite @tac0turtle
chore: upgrade to cosmos-sdk v0.46.16 (#357)
e04d485 
* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <[email protected]>

* fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.46.15 (cosmos#17408)

* fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527)

Co-authored-by: devon <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549)

Co-authored-by: Félix C. Morency <[email protected]>

* fix: typo in comment (backport cosmos#17635) (cosmos#17638)

Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Marko <[email protected]>

* build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare release notes v0.46.16 (cosmos#18118)

* fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260)

Co-authored-by: Julien Robert <[email protected]>

* chore: update tag date v0.46.16 (cosmos#18385)

* revert: Go 1.19

* revert: c226e8b

* chore(deps): upgrade to v1.29.0-tm-v0.34.29

* chore: downgrade to grpc 1.54.0

to match the versions used in upstream

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Devon Bear <[email protected]>
Co-authored-by: devon <[email protected]>
Co-authored-by: Félix C. Morency <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Marko <[email protected]>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @julienrbrt @JeancarloBarrios
fix: use correct config key for db_backend (backport cosmos#17406) (c…
296c03c 
…osmos#17412)

Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:Confix Issues and PR related to Confix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @tac0turtle @k-yang