-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in comment #17635
Merged
Merged
fix: typo in comment #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces "config.toml" with "client.toml" to avoid confusion between this and the cometbft config ("config.toml"); see: [server/main/util.go:236](https://github.com/cosmos/cosmos-sdk/blob/main/server/util.go#L236).
julienrbrt
added
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
labels
Sep 6, 2023
julienrbrt
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
github-prbot
requested review from
a team,
facundomedica and
testinginprod
and removed request for
a team
September 6, 2023 09:23
tac0turtle
approved these changes
Sep 6, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 01b8be0)
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 01b8be0) # Conflicts: # client/config/config.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 01b8be0) # Conflicts: # client/config/config.go
This was referenced Sep 6, 2023
tac0turtle
added a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bryan White <[email protected]> Co-authored-by: Marko <[email protected]>
tac0turtle
pushed a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bryan White <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bryan White <[email protected]> Co-authored-by: Julien Robert <[email protected]>
19 tasks
rootulp
pushed a commit
to rootulp/cosmos-sdk
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Bryan White <[email protected]> Co-authored-by: Marko <[email protected]>
rootulp
added a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Nov 14, 2023
* refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <[email protected]> * fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.46.15 (cosmos#17408) * fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527) Co-authored-by: devon <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549) Co-authored-by: Félix C. Morency <[email protected]> * fix: typo in comment (backport cosmos#17635) (cosmos#17638) Co-authored-by: Bryan White <[email protected]> Co-authored-by: Marko <[email protected]> * build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112) Co-authored-by: Julien Robert <[email protected]> * chore: prepare release notes v0.46.16 (cosmos#18118) * fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260) Co-authored-by: Julien Robert <[email protected]> * chore: update tag date v0.46.16 (cosmos#18385) * revert: Go 1.19 * revert: c226e8b * chore(deps): upgrade to v1.29.0-tm-v0.34.29 * chore: downgrade to grpc 1.54.0 to match the versions used in upstream --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Devon Bear <[email protected]> Co-authored-by: devon <[email protected]> Co-authored-by: Félix C. Morency <[email protected]> Co-authored-by: Bryan White <[email protected]> Co-authored-by: Marko <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
C:CLI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces "config.toml" with "client.toml" to avoid confusion between this and the cometbft config ("config.toml"); see: server/main/util.go:236.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change