Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip handling #488

Closed
jakirkham opened this issue Mar 21, 2017 · 6 comments
Closed

Fix skip handling #488

jakirkham opened this issue Mar 21, 2017 · 6 comments
Labels

Comments

@jakirkham
Copy link
Member

jakirkham commented Mar 21, 2017

It appears that commit ( 75dc6bf ) from PR ( #479 ) results in some unintended skips as demonstrated by PR ( conda-forge/viridis-feedstock#4 ). Will need to investigate a fix that still has the intended behavior.

Edit: Another example is PR ( conda-forge/qcodes-feedstock#1 ).

@jakirkham jakirkham added the bug label Mar 21, 2017
@jakirkham
Copy link
Member Author

cc @johanneskoester @jni

@jakirkham
Copy link
Member Author

When inspecting the meta, we find that all cases result in skip being True. We are going to need look for some more specific information if about the skip conditions, but will need to figure out where.

@johanneskoester
Copy link
Contributor

Alternatively, one could still try to find the conda/conda-build combination where the computation works without a problem. This should be doable by using my test case, deactivating the skipping, and checking where it crashes.

@jakirkham
Copy link
Member Author

Thanks for the suggestion, @johanneskoester. I'll keep it in mind when I have time to do more debugging.

@jakirkham
Copy link
Member Author

Fixed by PR ( #493 ).

@jakirkham
Copy link
Member Author

The fix is being released in conda-smithy 2.2.2.

xref: conda-forge/conda-smithy-feedstock#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants