Handle all cases of missing packages when building version matrix. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Mar 22, 2017
| @@ -2,3 +2,4 @@ conda >=4 | |||
| conda-build >=1.21.7 | |||
| anaconda-client | |||
| mock | |||
| requests==2.11 # work around conda/conda#3947 | |||
|
@marqh, could you please take a look at this when you have a chance? |
|
this change makes sense, it seems like a light touch do you require a release and a build in order to obtain benefit from this change? |
|
I think that would be ideal, right @jakirkham? |
|
Yep, a release would be great. |
|
Thanks @marqh! |
|
Awesome thanks @marqh and @johanneskoester! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, when creating a version matrix, conda-build-all only skipped cases where a specific version was missing or infeasible. This PR fixes a crash when a particular package was not available at all for a certain platform, see conda-forge/conda-smithy#488.
Further, I have fixed the failing test cases, by taking updated conda versions from conda-forge and pinning to requests-2.11 (see conda/conda#3947).