[WIP] Remove skip from compute_build_matrix #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @johanneskoester this is much better then the previous fix 😉 |
ocefpaf
reviewed
Mar 22, 2017
| @@ -30,6 +30,7 @@ install: | |||
| # Now do the things we need to do to install it. | |||
| - conda install --file requirements.txt coverage=3 python-coveralls mock python=${PYTHON} ${CONDA_PKGS} --yes --quiet -c conda-forge | |||
| - python setup.py install | |||
| - pip install git+https://github.com/johanneskoester/conda-build-all.git | |||
There was a problem hiding this comment.
If SciTools folks takes too long to merge that we can add this as a patch on our own packaged version of conda-build-all and drop the patch once they merge it.
|
Maybe cleanup the commit history a bit. Good once we have a |
|
Don't you do a squash or merge commit? |
|
Closing in favor of #493. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, fix issue #488 by changes to conda-build-all, see conda-tools/conda-build-all#82.
Currently, this PR pulls conda-build-all from my fork for demonstration. Once conda-tools/conda-build-all#82 has been merged and released, we can update the dependency of conda-smithy.