Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Re-render the feedstock [ci skip] #6

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I've re-rendered this feedstock with the latest version of conda-smithy (2.2.1) and noticed some changes.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).

Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package.
Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.

Thanks!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is off with this re-rendering. Potentially pertaining to issue ( conda-forge/conda-smithy#488 ). Will revisit after we fix that issue.

@@ -1,40 +0,0 @@
# This file was generated automatically from conda-smithy. To update this configuration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be removed.

@@ -1,71 +0,0 @@
# This file was automatically generated by conda-smithy. To update a component of this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be removed.

@jakirkham
Copy link
Member

xref: conda-forge/conda-smithy#488

@jakirkham
Copy link
Member

Closing. Fix is in conda-smithy 2.2.2. Creating a re-rendering with it should resolve this issue.

@jakirkham jakirkham closed this Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants