Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Re-render the feedstock [ci skip] #5

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I've re-rendered this feedstock with the latest version of conda-smithy (2.1.0) and noticed some changes.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).

Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package.
Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.

Thanks!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems related to issue ( conda-forge/conda-smithy#257 ). Interestingly this didn't affect the CircleCI portion, which does build Python 3 currently.

.travis.yml Outdated
@@ -10,8 +10,6 @@ env:
matrix:

- CONDA_PY=27
- CONDA_PY=35
- CONDA_PY=36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3 should not be dropped.

appveyor.yml Outdated

- TARGET_ARCH: x64
CONDA_PY: 36
CONDA_INSTALL_LOCN: C:\\Miniconda35-x64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3 should not be dropped.

@pmlandwehr pmlandwehr dismissed jakirkham’s stale review February 26, 2017 20:57

Changes reverted!

@jakirkham
Copy link
Member

Thanks @pmlandwehr. I guess the question is why did this happen in the first place. Though that's really on me to look into.

@pmlandwehr pmlandwehr merged commit 4c566bd into conda-forge:master Mar 2, 2017
@jakirkham
Copy link
Member

Looks like this was related to issue ( conda-forge/conda-smithy#488 ). As such it is fixed in conda-smithy 2.2.2. Have re-rendered locally to verify this is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants