Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink testParDoRequiresStableInput flaky #21333

Open
damccorm opened this issue Jun 4, 2022 · 4 comments · Fixed by #22889
Open

Flink testParDoRequiresStableInput flaky #21333

damccorm opened this issue Jun 4, 2022 · 4 comments · Fixed by #22889

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20253/

org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInput

java.util.concurrent.ExecutionException: java.util.concurrent.CompletionException: org.apache.flink.runtime.checkpoint.CheckpointException: Checkpoint triggering task Source: Impulse -> CreatePCollectionOfOneValue/Read(CreateSource)/ParDo(OutputSingleSource)/ParMultiDo(OutputSingleSource) -> CreatePCollectionOfOneValue/Read(CreateSource)/ParDo(BoundedSourceAsSDFWrapper)/ParMultiDo(BoundedSourceAsSDFWrapper)/Pair with initial restriction/ParMultiDo(PairWithRestriction) -> CreatePCollectionOfOneValue/Read(CreateSource)/ParDo(BoundedSourceAsSDFWrapper)/ParMultiDo(BoundedSourceAsSDFWrapper)/Split restriction/ParMultiDo(SplitRestriction) -> CreatePCollectionOfOneValue/Read(CreateSource)/ParDo(BoundedSourceAsSDFWrapper)/ParMultiDo(BoundedSourceAsSDFWrapper)/Explode windows/ParMultiDo(ExplodeWindows) -> CreatePCollectionOfOneValue/Read(CreateSource)/ParDo(BoundedSourceAsSDFWrapper)/ParMultiDo(BoundedSourceAsSDFWrapper)/Assign unique key/AddKeys/Map/ParMultiDo(Anonymous) -> ToKeyedWorkItem (1/1) of job 7bbb425ba325dbc1dc4d3cdf1c8b88f9 is not being executed at the moment. Aborting checkpoint. Failure reason: Not all required tasks are currently running.

Imported from Jira BEAM-13575. Original Jira may contain additional context.
Reported by: ibzib.

@kennknowles
Copy link
Member

@je-ik is working on support for this in some cases. Might know something about this one.

@kennknowles kennknowles removed their assignment Dec 7, 2022
@je-ik
Copy link
Contributor

je-ik commented Dec 8, 2022

This does not seem related to the functionality itself, looks like the test is missing some synchronization. I'll take a look.

@je-ik je-ik self-assigned this Dec 12, 2022
je-ik added a commit to je-ik/beam that referenced this issue Jan 3, 2023
 Fix FlinkRequiresStableInputTest flakiness (apache#21333)
lukecwik added a commit that referenced this issue Jan 23, 2023
* Handle @RequiresStableInput in portable flink (#20812)

* [runners-flink] Remove unnnecessary dependency on flink-annotations

* Fix @RequiresStableInput for portable Flink (#20812)

 Fix FlinkRequiresStableInputTest flakiness (#21333)

* Flink: Tests for stateful stable dofns (#20812)

* Enable commit for kafka flink portable test

* Apply suggestions from code review

Co-authored-by: Lukasz Cwik <[email protected]>

* Add callback to BufferingDoFnRunner for flushing SDK harness results

* revert changes in website

Co-authored-by: Lukasz Cwik <[email protected]>
@github-actions github-actions bot added this to the 2.46.0 Release milestone Jan 23, 2023
@Abacn
Copy link
Contributor

Abacn commented Apr 18, 2023

It's appearing again in https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/6030/

Test Result (2 failures / +2)
org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInputPortable
org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInputStatefulPortable

Error message:

org.junit.runners.model.TestTimedOutException: test timed out after 30000 milliseconds
	at java.lang.Thread.sleep(Native Method)
	at org.apache.beam.runners.flink.FlinkRequiresStableInputTest.executePipeline(FlinkRequiresStableInputTest.java:187)
	at org.apache.beam.runners.flink.FlinkRequiresStableInputTest.runTest(FlinkRequiresStableInputTest.java:160)
	at org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInputPortable(FlinkRequiresStableInputTest.java:112)

@Abacn Abacn reopened this Apr 18, 2023
@Abacn Abacn removed this from the 2.46.0 Release milestone Apr 18, 2023
@Abacn
Copy link
Contributor

Abacn commented Apr 18, 2023

Downgrade to P2 as the issue is more likely due to Jenkins under high load. The functionality itself is implemented in #22889

minxhe pushed a commit to minxhe/beam that referenced this issue Nov 25, 2024
* [runners-flink] Remove unnnecessary dependency on flink-annotations

* Fix @RequiresStableInput for portable Flink (apache#20812)

 Fix FlinkRequiresStableInputTest flakiness (apache#21333)

* Flink: Tests for stateful stable dofns (apache#20812)

* Enable commit for kafka flink portable test

* Apply suggestions from code review

Co-authored-by: Lukasz Cwik <[email protected]>

* Add callback to BufferingDoFnRunner for flushing SDK harness results

* revert changes in website

Co-authored-by: Lukasz Cwik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants