Spanner - add default retryable codes #26727
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java_GCP_IO_Direct PreCommit |
|
FYI @riteshghorse, Spanner wants to get this in before cut for 2.48.0. |
|
R: @Abacn for final approval |
|
Run Java PreCommit |
.../google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
Outdated
Show resolved
Hide resolved
Ack |
|
I'll merge once all tests passes. |
|
Run Java PreCommit |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
I think Java PreCommit failure is unrelated to this PR. |
|
Yes. The failure is not related to this PR and it is flaky. It had passed a couple of runs back. |
|
https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/6867/ looks like test timed out failure from this build Can someone from Java take a look, @Abacn what do you think? |
|
Yes it's known issue (#21333), when jenkins gets more heavy load it's timing out more likely. Current practice is go ahead it |
|
btw Java PreCommit even should not trigger in this PR by default as it only touches source under |
|
thanks y'all |
| @@ -113,6 +113,8 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) { | |||
| SpannerOptions.Builder builder = SpannerOptions.newBuilder(); | |||
|
|
|||
| Set<Code> retryableCodes = new HashSet<>(); | |||
| // Add default retryable codes | |||
| retryableCodes.add(Code.UNAVAILABLE); | |||
There was a problem hiding this comment.
Could there be a scenario where a user does not want to retry on UNAVAILABLE?
This code would always add UNAVAILABLE even if the user specified their own set of retryable codes, and could therefore lead to unexpected behaviour..
There was a problem hiding this comment.
Resolved by other changes.
Lgtm
* Add default retryable codes * reading default codes from the settings * reading default codes from the settings * spotless fix * Distinguish unary method retryable codes and streaming method retryable codes * spotless fix
Spanner - add default retryable codes
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.