Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable local build caching for CI builds #26784

Merged
merged 1 commit into from
May 19, 2023

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented May 19, 2023

Before #26351, builds had the local build cache enabled for local development builds as well as CI builds. #26351 inadvertenly disabled the local build cache for CI builds. This re-enables it.

You can see in this Gradle Enterprise graph that the local build cache was disabled for CI builds.

Fixes #26776


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Before apache#26351, builds had the local build cache enabled for local development builds as well as CI builds. apache#26351 inadvertenly disabled the local build cache for CI builds. This re-enables it.

Fixes apache#26776
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #26784 (39f5c05) into master (809d4b3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26784      +/-   ##
==========================================
- Coverage   71.98%   71.97%   -0.02%     
==========================================
  Files         747      747              
  Lines      101306   101306              
==========================================
- Hits        72927    72911      -16     
- Misses      26920    26936      +16     
  Partials     1459     1459              
Flag Coverage Δ
python 80.94% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor

Run Java PreCommit

@damccorm
Copy link
Contributor

Run Java_PVR_Flink_Batch PreCommit

@damccorm
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

@Abacn
Copy link
Contributor

Abacn commented May 19, 2023

Flink tests known flake: #21333 not related (this flakiness happens more frequently since then, also), merging for now.

@Abacn Abacn merged commit 4a54092 into apache:master May 19, 2023
@runningcode runningcode deleted the no/enable-local-cache branch May 19, 2023 14:47
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Before apache#26351, builds had the local build cache enabled for local development builds as well as CI builds. apache#26351 inadvertenly disabled the local build cache for CI builds. This re-enables it.

Fixes apache#26776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Jenkins builds taking longer since May 12th, seems gradle cache no longer work
3 participants