Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Libraries BOM version to 26.14.0 #26525

Merged
merged 1 commit into from
May 4, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented May 3, 2023

Update google_cloud_platform_libraries_bom version. Update gax, spanner and grpc versions to be consistent with the versions in google_cloud_platform_libraries_bom.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@suztomo suztomo changed the title Update libraries bom version GCP Libraries BOM version to 26.14.0 May 3, 2023
@suztomo
Copy link
Contributor

suztomo commented May 3, 2023

Looks good to me. Let's see the test results.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #26525 (c7f2c64) into master (a13749f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26525      +/-   ##
==========================================
+ Coverage   81.11%   81.13%   +0.02%     
==========================================
  Files         469      469              
  Lines       67438    67438              
==========================================
+ Hits        54705    54719      +14     
+ Misses      12733    12719      -14     
Flag Coverage Δ
python 81.13% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor

Abacn commented May 3, 2023

Run Java_IOs_Direct PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented May 3, 2023

Run SQL PreCommit

@Abacn
Copy link
Contributor

Abacn commented May 3, 2023

beam_PreCommit_Java_Commit testParDoRequiresStableInputPortable known flake: #21333
beam_PreCommit_Java_PVR_Flink_Batch_Commit known timeout flake: #26301

other tests all succeeded

@suztomo
Copy link
Contributor

suztomo commented May 3, 2023

Run SQL Postcommit

SQL post commit failed. Retrying.

com.google.api.gax.rpc.DeadlineExceededException: io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: Deadline expired before operation could complete.
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:94)

@suztomo
Copy link
Contributor

suztomo commented May 4, 2023

Run SQL Postcommit

@suztomo
Copy link
Contributor

suztomo commented May 4, 2023

@Abacn Do we wait until the flakes are resolved or merge this without waiting for them?

@Abacn
Copy link
Contributor

Abacn commented May 4, 2023

@Abacn Do we wait until the flakes are resolved or merge this without waiting for them?

The traceback shows a grpc exception and the version bump included grpc, we can wait until the trigger run ends. Jenkins was in restart mode and there is a long queue and now is back. Trigger job should be completed soon.

@suztomo
Copy link
Contributor

suztomo commented May 4, 2023

Run Java PreCommit

@mutianf
Copy link
Contributor Author

mutianf commented May 4, 2023

Do we have to update the grpc version to be in sync with libraries bom? If grpc is the only concern / causing failures I could revert the grpc change

def google_code_gson_version = "2.9.1"
def google_oauth_clients_version = "1.34.1"
// Try to keep grpc_version consistent with gRPC version in google_cloud_platform_libraries_bom
def grpc_version = "1.53.0"
def grpc_version = "1.54.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed, should be good to go

@Abacn Abacn merged commit c7458a3 into apache:master May 4, 2023
@mutianf mutianf deleted the update-libraries-bom branch May 4, 2023 15:41
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants