-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP Libraries BOM version to 26.14.0 #26525
Conversation
Looks good to me. Let's see the test results. |
Codecov Report
@@ Coverage Diff @@
## master #26525 +/- ##
==========================================
+ Coverage 81.11% 81.13% +0.02%
==========================================
Files 469 469
Lines 67438 67438
==========================================
+ Hits 54705 54719 +14
+ Misses 12733 12719 -14
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Java_IOs_Direct PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run SQL PreCommit |
Run SQL Postcommit SQL post commit failed. Retrying.
|
Run SQL Postcommit |
@Abacn Do we wait until the flakes are resolved or merge this without waiting for them? |
The traceback shows a grpc exception and the version bump included grpc, we can wait until the trigger run ends. Jenkins was in restart mode and there is a long queue and now is back. Trigger job should be completed soon. |
Run Java PreCommit |
Do we have to update the grpc version to be in sync with libraries bom? If grpc is the only concern / causing failures I could revert the grpc change |
def google_code_gson_version = "2.9.1" | ||
def google_oauth_clients_version = "1.34.1" | ||
// Try to keep grpc_version consistent with gRPC version in google_cloud_platform_libraries_bom | ||
def grpc_version = "1.53.0" | ||
def grpc_version = "1.54.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo. 1.54.0 is correct value.
gRPC: 1.54.0
https://github.com/googleapis/java-cloud-bom/releases/tag/v26.14.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed, should be good to go
Update google_cloud_platform_libraries_bom version. Update gax, spanner and grpc versions to be consistent with the versions in google_cloud_platform_libraries_bom.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.