-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address breaking change on nightly #226
Conversation
Fix to [225](#225)
Let's wait for Compat to support this so this can be done as |
The new version of Compat is now in METADATA so this can be updated |
src/Writer.jl
Outdated
@@ -1,5 +1,6 @@ | |||
module Writer | |||
|
|||
using Compat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also need a using Compat.Dates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalimilan is the using Compat.Dates
required as well? The documentation in Compat wasn't very clear on it, but let double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you need to replace Base.Dates
with Compat.Dates
everywhere it appeared. So I now realize JuliaData/Missings.jl#56 didn't change anything to the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the case at hand, you just need to replace Dates
with Compat.Dates
on this line:
Line 52 in b4a4e33
Dates.TimeType, Char, Type, AbstractString, Enum, Symbol} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us check change it and check Travis. After the manual fix both packages compiled so the CI should be cleared.
There's no performance difference between |
Hi @Nosferican, thank you for the contribution! I went ahead and removed the |
Fix to 225