Skip to content

Commit

Permalink
Added Compat.Dates to all files that required it
Browse files Browse the repository at this point in the history
  • Loading branch information
Nosferican committed Nov 24, 2017
1 parent 81fd738 commit 7eefadc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion test/REQUIRE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DataStructures
FixedPointNumbers
OffsetArrays
Compat 0.31.0
Compat 0.37.0
1 change: 1 addition & 0 deletions test/lowering.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module TestLowering

using JSON
using Compat.Test
using Compat.Dates
using FixedPointNumbers: Fixed

if isdefined(Base, :Dates)

This comment has been minimized.

Copy link
@nalimilan

nalimilan Nov 24, 2017

Member

This line was likely there to support old Julia versions, the condition should be removed now since it will always be false in the future.

Expand Down
1 change: 1 addition & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using JSON
using Compat.Test
using Compat
using Compat.Dates

This comment has been minimized.

Copy link
@nalimilan

nalimilan Nov 24, 2017

Member

It would be nice to find another approach which doesn't require importing all of Dates. The old code worked without, so couldn't the new one do the same? By always qualifying objects with Compat.Dates, it should work.

using OffsetArrays

import DataStructures
Expand Down

0 comments on commit 7eefadc

Please sign in to comment.