Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movement of Dates on Nightly #225

Closed
Nosferican opened this issue Nov 22, 2017 · 3 comments
Closed

Movement of Dates on Nightly #225

Nosferican opened this issue Nov 22, 2017 · 3 comments

Comments

@Nosferican
Copy link
Contributor

Nosferican commented Nov 22, 2017 •
edited
Loading

Since Julia 0c0d6cc JSON fails to compile due to Writer.jl

const IsPrintedAsString = Union{
    Dates.TimeType, Char, Type, AbstractString, Enum, Symbol}

which gives

ERROR: LoadError: LoadError: type Void has no field TimeType

Fix is to add the line to Writer.jl

import Dates
@Nosferican Nosferican mentioned this issue Nov 22, 2017
Merged
@KristofferC
Copy link
Member 

if VERSION >= v"0.7.0-DEV.2575"
    import Dates
end

@Nosferican
Copy link
Contributor Author

Thanks!

TotalVerb pushed a commit that referenced this issue Nov 24, 2017
@Nosferican @TotalVerb
Address breaking change on nightly (#226)
0b191d9 
* Address breaking change on nightly

Fix to [225](#225)

* Compatibility fix

* Compat to handle Dates

* Added Compat.Dates

* Added Compat.Dates to all files that required it

* Remove isdefined(Base, :Dates) check
@TotalVerb
Copy link
Collaborator

Closed by #226.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KristofferC @Nosferican @TotalVerb