Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address breaking change on nightly #226

Merged
merged 6 commits into from
Nov 24, 2017
Merged

Address breaking change on nightly #226

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b55bec3
Address breaking change on nightly
Nosferican Nov 22, 2017
f9c2199
Compatibility fix
Nosferican Nov 22, 2017
2095cd9
Compat to handle Dates
Nosferican Nov 24, 2017
81fd738
Added Compat.Dates
Nosferican Nov 24, 2017
7eefadc
Added Compat.Dates to all files that required it
Nosferican Nov 24, 2017
32b4dc9
Remove isdefined(Base, :Dates) check
TotalVerb Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion REQUIRE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
julia 0.6
Compat 0.33.0
Compat 0.37.0
1 change: 1 addition & 0 deletions src/Writer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module Writer

using Compat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need a using Compat.Dates

Copy link
Contributor Author

@Nosferican Nosferican Nov 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nalimilan is the using Compat.Dates required as well? The documentation in Compat wasn't very clear on it, but let double check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you need to replace Base.Dates with Compat.Dates everywhere it appeared. So I now realize JuliaData/Missings.jl#56 didn't change anything to the problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the case at hand, you just need to replace Dates with Compat.Dates on this line:

JSON.jl/src/Writer.jl

Line 52 in b4a4e33

Dates.TimeType, Char, Type, AbstractString, Enum, Symbol}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us check change it and check Travis. After the manual fix both packages compiled so the CI should be cleared.

using ..Common
using ..Serializations: Serialization, StandardSerialization,
CommonSerialization
Expand Down