Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger refresh on hotswap only for redefined classes (#20684) (CP: 24.5) #20752

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Prevent hotswapper to trigger a refresh when the classes are loaded for the
first time. Refreshing a view should make sense only if a project class has
been modified. The only exception is auto layout classes, that must be
applied even if they are not directly references in the component tree.

Fixes #20680
Fixes #20681
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 19, 2024 08:37
Copy link

Test Results

1 148 files  ± 0  1 148 suites  ±0   1h 27m 42s ⏱️ + 4m 51s
7 539 tests +11  7 486 ✅ +11  53 💤 ±0  0 ❌ ±0 
7 910 runs  +13  7 847 ✅ +13  63 💤 ±0  0 ❌ ±0 

Results for commit d68ae71. ± Comparison against base commit fe150d1.

@vaadin-bot vaadin-bot merged commit 5483617 into 24.5 Dec 19, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20684-to-24.5-1734597075881 branch December 19, 2024 08:47
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants